Allow a null revoke OAuth URL on the Google Cloud panel

Anna Vovchenkorequested to merge
fix-google-cloud-revoke-oauth-url-prop into master

revokeOauthUrl is declared required: true on the Google Cloud configuration panel, but the controller returns nil whenever the Google token check fails, and the panel already guards the value with v-if. Vue logs a prop type warning on every load of the page in that state.

The prop is now optional with a null default, matching what the template already assumes.

Verification

With required: true restored, the added example logs:

  • Vue 2: [Vue warn]: Invalid prop: type check failed for prop "revokeOauthUrl". Expected String, got Null
  • Vue 3: Expected String with value "null", got Null

The spec passes either way, which is why this went unnoticed.

  • yarn jest spec/frontend/google_cloud/configuration — 5 passed
  • VUE_VERSION=3 yarn jest spec/frontend/google_cloud/configuration — 5 passed

The other required: true props in ~/google_cloud are correct as they stand: gcp_regions/list.vue and service_accounts/list.vue guard their list prop on list.length === 0, and their controllers always pass an array.

Merge request reports