Bump gitlab-shell to 14.56.1 in 19.1 (gitlab-sshd CPU spin fix)
What does this MR do and why?
Backport of the gitlab-sshd CPU spin fix to 19.1.
GitLab 19.1 ships gitlab-shell 14.54.0, which pins golang.org/x/crypto
v0.52.0. That crypto release has a spinloop bug in ssh mux SendRequest:
gitlab-sshd instances with ClientAliveInterval > 0 can pin CPU cores at
100% and leak goroutines when a keepalive fires as its connection is torn
down.
This MR bumps GITLAB_SHELL_VERSION to 14.56.1, which moves to
golang.org/x/crypto v0.54.0 and carries the upstream fix. This is the
same gitlab-shell release already shipping in 19.2 and 19.3.
- Fix (gitlab-shell): gitlab-shell!1517 (merged)
- Ref (work item): gitlab-shell#876 (closed)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
- This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
- The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
- The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
- Required labels have been applied to this merge request
- severity label and bug subtype labels (if applicable)
- If this MR fixes a bug that affects customers, the customer label has been applied.
- This MR has been approved by a maintainer (only one approval is required).
- Ensure the
e2e:test-on-omnibus-eejob has succeeded, or if it has failed, investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releasesSlack channel (internal only). - Once the backport has been merged, the commit changes will be automatically deployed to a release environment that can be used for manual validation. See after merging runbook for details.