Skip to content

Fix k8s namespace resolution for new deployments

What does this MR do?

When working on !25845 (merged) I found a leftover use of the last successful deployment for resolving the namespace for the next deployment. This means custom namespaces are not always persisted correctly in DeploymentCluster, and hence don't always show up correctly on the job show page 😢

I already fixed several such cases in !20983 (merged), but this one slipped through the cracks 😕

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports