Loading
Make advanced configuration editable in the scan profile form
What does this MR do and why?
Wires <advanced-configuration-table> into <advanced-configuration-editor> so a profile's configured variables can be viewed and edited directly in the create/edit form, instead of only being viewable after saving. Each configurable trigger gets its own row in the expanded view: a boolean renders as an Enabled/Disabled radio group, an enum as a dropdown built from the variable catalog, everything else as a text input, each with a remove action next to it.
References
- issue: [Frontend] Scan profile drawer: view, create, e... (#624191 - closed)
- parent work item: Advanced Configuration Profiles for Security Sc... (gitlab-org#20193)
- Design:
security-inventory-profiles
Screenshots or screen recordings
| Before | After |
|---|---|
|
The 'advanced-configuration-table' doesn't exist on this page yet. |
|
|
no changes
|
How to set up and validate locally
- Enable the
custom_scan_profiles_uifeature flag. - Go to Security configuration, pick a scanner that supports profiles (e.g. Secret Detection), and open Manage profiles.
- Create or edit a profile, enable at least two triggers, click Add variable, pick
Image variant, choose Default, and save — the button is now enabled and the row shows up with the "Default" label instead of nothing. - Add a second variable (e.g.
Historic scan), expand its row, and edit a single trigger's value directly — the change should save without touching the others. - Remove a trigger's value (the trash icon) while another trigger still has it set — the row should stay in its original position and show an empty, editable field for that trigger, not disappear.
- Toggle on a previously-disabled trigger while other triggers already share a configured value — the newly enabled trigger should start with the same value instead of blank.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Chen Charnolevsky

