Loading
Remove the Security Manager New badge
What does this MR do and why?
The Security Manager role went GA in 19.1 and we are on 19.5, so the promotional "New" badge and its "Security Manager role now available" popover are stale.
- Deleted
security_manager_new_badge.vueand its spec. - Removed the usage, import and
componentsentry fromrole_selector.vueandroles_table.vue. - Dropped the now-unused
ACCESS_LEVEL_SECURITY_MANAGER_STRINGimport and theisSecurityManagerRolemethod, since the badge was their only consumer. - Folded Security Manager back into the
describe.each(standardRoles)loop in the roles table spec. It had been filtered out only because the New badge rendered aGlBadgeand tripped the "does not show custom role badge" assertion.
The promotional banner half of this was already removed when it was reverted in July, so the badge was all that remained.
Approved by product for this milestone in #601418 (closed).
How to set up and validate locally
yarn jest spec/frontend/members spec/frontend/access_level ee/spec/frontend/roles_and_permissions1401 tests, 0 failures.
References
Related cleanup: #584144 (closed)
Screenshots or screen recordings
| Before | After |
|---|---|
![]() |
![]() |
Edited by Diane Russel

