Skip to content

Restyle MR approval popover

Samantha Ming requested to merge 207450-adjust-style-in-mr-approval-popover into master

Issue: #207450 (closed)

What does this MR do?

Restyle the link in the popover to be consistent with the test and on click, it opens the information on a new page.

image

Testing Case

  1. Navigate to General project settings
  2. Expand the Merge request approvals section
  3. Attempt to hover on the question mark icon next to the default approval rule (“Any eligible user”)

image

  • More information has the same text size as the popover
  • On click, it will open the information on a new page

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #207450 (closed)

Edited by Samantha Ming

Merge request reports

Loading