Skip to content

Tweak wiki page title handling

Markus Koller requested to merge 16131-wiki-titles-with-special-characters into master

What does this MR do?

Adresses the changed behaviour in https://gitlab.com/gitlab-org/gollum-lib/-/merge_requests/10

  • Add specs for handling of special characters.
  • Fix title_changed? for all cases.
  • Remove redundant persisted argument.
  • Don't unescape title returned by gollum, it's not escaped anymore now.

Ref: #16131 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports