Skip to content

Expose assets filepath URL on UI

Sean Carroll requested to merge 27300-expose-filepath-url-on-ui into master

What does this MR do?

Provide the frontend component of the asset link redirection. Visually nothing will change, but the link will actually the direct_asset_url rather than url, and will redirect in the backend.

On the release/releases page, instead of linking the linux amd64 file of v11.9.0-rc2 release as https://gitlab-runner-downloads.s3.amazonaws.com/v11.9.0-rc2/binaries/gitlab-runner-linux-amd64 (the target URL where the file is stored) it should be linked as https://gitlab.com/gitlab-org/gitlab-runner/releases/v11.9.0-rc2/binaries/gitlab-runner-linux-amd64. Notice that the filepath is added to the release direct page.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Part of #27300 (closed)

Edited by Sean Carroll

Merge request reports