Remove Security Manager gate from access name helper

Diane Russelrequested to merge
cleanup/remove-security-manager-helper-gate into master

What does this MR do and why?

SecurityManagerConfig.enabled? returns a literal true, so localized_security_manager_role_name always returns the role name. Its one caller now uses _('Security Manager') directly.

  • Deleted the helper. Its comment said it existed "to solve rubocop error of line too long", and rubocop is clean on the inlined line.
  • Removed the .compact on localized_access_names. It arrived in the same commit as the helper, b5ece87c87f88, which changed } to }.compact. Every remaining entry is a _() call, so nothing can be nil.

locale/gitlab.pot needs no regeneration. It carries no file:line references and already contains Security Manager.

How to set up and validate locally

bundle exec rspec spec/helpers/projects_helper_spec.rb

219 examples, 0 failures.

References

#584144 (closed)

Part of the work in !239507 (closed)

Screenshots or screen recordings

No UI change. localized_project_human_access returned "Security Manager" before and after.

🤖 Generated with Claude Code

Merge request reports