Remove Security Manager gate from access options

What does this MR do and why?

SecurityManagerConfig.enabled? returns a literal true, so the ternaries in Gitlab::Access.options and .option_descriptions always take the present branch.

• Unwrapped both ternaries.
• Removed both .compact calls. They arrived in the same commit as the gate, 553e99484e27, purely to strip the nil it produced, and now have nothing to remove.

Dropping .compact is safe. Every remaining entry in options is a constant and every entry in option_descriptions is an s_() call, and EE's override at ee/lib/ee/gitlab/access.rb:47 is super.merge with a non-nil value, so no entry can be nil.

This is the hub of the series. Six disabled-state spec contexts used to hang off these two methods, and they went in !256056 (merged), so there are no spec changes here.

How to set up and validate locally

bundle exec rspec spec/lib/gitlab/access_spec.rb ee/spec/lib/ee/gitlab/access_spec.rb spec/presenters/member_presenter_spec.rb spec/presenters/group_member_presenter_spec.rb ee/spec/graphql/resolvers/members/standard_roles_resolver_spec.rb ee/spec/lib/gitlab/custom_roles/definition_spec.rb spec/serializers/projects/project_members/app_data_serializer_spec.rb

171 examples, 0 failures.

References

#584144 (closed)

Part of the work in !239507 (closed)

Screenshots or screen recordings

No UI change.

🤖 Generated with Claude Code