Loading
Drop stale with_actor(nil) scaffolding from CI config specs
What does this MR do and why?
Removes Gitlab::Ci::Config::FeatureFlags.with_actor(nil) scaffolding from four CI config
spec files. The flags these blocks were added for no longer exist.
spec/spec_helper.rb wraps every example in FeatureFlags.ensure_correct_usage, so a flag
read with no actor fails the spec. with_actor(nil) makes current_actor return nil
without raising. While the block is in place, a future flag added to these code paths
without a real actor evaluates against nil instead of failing the spec.
Related
Edited by Oleg Yakovenko