Backport 'Drop system failure assertion in secrets specs' to 19-2-stable-ee

What does this MR do and why?

Backport of !255999 (merged) and !256018 (merged) to 19-2-stable-ee.

Removes the expect(trace).to have_content('ERROR: Job failed (system failure)') assertion from the project-level and group-level Secrets Manager E2E specs. gitlab-runner 19.4.0 no longer classifies a failed CI secret resolution as a system failure, so this assertion can never pass again. The remaining expectations still verify the spec's contract.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
  • Required labels have been applied to this merge request
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the E2E Omnibus GitLab EE pipeline (triggered by thee2e:test-on-omnibus-ee job) has succeeded. If it has failed (or shows warnings), investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Fabien Catteau

Merge request reports

Loading
Loading