Remove GITLAB_SECURITY_MANAGER_ROLE env var

Diane Russelrequested to merge
cleanup/remove-security-manager-env-var into master

What does this MR do and why?

The Security Manager role is generally available and the env var default was flipped to true in June. The opt-out is still in the code, so an instance can turn the role off by setting one variable. It is undocumented and not in charts or omnibus.

  • SecurityManagerConfig.enabled? returns true. The class stays until its remaining call sites are removed.
  • Dropped ENV["GITLAB_SECURITY_MANAGER_ROLE"] from spec/spec_helper.rb.
  • The :disable_security_manager tag stubs the method now instead of the env var, so the specs covering the disabled state keep passing.

First of several. Follow-ups remove the 9 call sites, then the class, then the pinned value in k8s-workloads. No behaviour change.

How to set up and validate locally

bundle exec rspec spec/lib/gitlab/access_spec.rb spec/graphql/types/access_level_enum_spec.rb
bundle exec rspec spec/presenters/group_member_presenter_spec.rb ee/spec/lib/gitlab/custom_roles/definition_spec.rb ee/spec/graphql/types/gitlab_subscriptions/user_role_enum_spec.rb

144 examples, 0 failures.

References

#584144 (closed). Supersedes the env var part of !239507 (closed).

Screenshots or screen recordings

No UI change.

🤖 Generated with Claude Code

Merge request reports