Skip to content

Fix instance variables access to several nuget services

What does this MR do?

During the implementation of the NuGet packages support (spanning over several MRs), services and presenters have been created. At this time, I thought that it was a convention to have a attr_reader to access instance variables. During one of the last MRs, I was called out for using attr_reader and exposing the internal state of objects. Exposing those can be considered as a code smell.

I hate leaving code smells behind my work, as such, this tiny MR revisits all the NuGet services and presenters and removes the attr_reader access as it's not needed. Instance variables will be accessed by the standard way: using directly @XXX variables.

Screenshots

n/a

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by David Fernandez

Merge request reports