Loading
Remove the duplicate tool coverage status mapping
What does this MR do and why?
Remove the duplicate tool coverage status mapping
Delete TOOL_STATUS_TO_AGGREGATE_VARIABLES and read the tool coverage
card's all-scanners variables from STATUS_FILTER_TO_VARIABLES instead,
keyed through a new TOOL_STATUS_TO_STATUS_FILTER map. Both objects
held the same four status-to-variable pairs, so a coverage state had
to be declared twice or the card and the search bar would disagree
about what it filters. Only the key translation is left, because the
card names its states SUCCESS and NOT_CONFIGURED where the search bar
says PROTECTED and UNPROTECTED.References
- issue: Frontend: Security inventory: add filters to UR... (#580024 - closed)
- split from: Draft: Sync security inventory filters with URL... (!252968 - closed)
Screenshots or screen recordings
no visual changes expected
How to set up and validate locally
-
git checkout 580024-remove-duplicate-status-mapping-in-security-inventory echo "Feature.enable(:security_inventory_tool_coverage_card)" | gdk rails c - have a GitLab Ultimate licence
- go to a group =>
Secure=>Security inventory - check that the tool coverage card is shown with the scanner dropdown on
All scanners
to check the card filters
- keep the scanner dropdown on
All scanners - click each of the four statuses on the card in turn:
EnabledFailedStaleNot enabled
- check that each one filters the project list, and that clicking it again clears the filter
to check the search bar filters
- with
All scannersselected, click a card status - note the project list
- clear the card selection, then apply the matching search bar filter from
Status - check that the two lists are identical for each pair:
- card
EnabledandStatusisProtected - card
FailedandStatusisNeeds attention - card
StaleandStatusisHas stale scans - card
Not enabledandStatusisUnprotected
- card
to run tests
yarn jest ee/spec/frontend/security_inventoryMR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #580024 (closed)
Edited by Miranda Fluharty