Remove unused scope Nuget::Package.without_nuget_temporary_name

Summary

Removes the unused scope Packages::Nuget::Package.without_nuget_temporary_name from app/models/packages/nuget/package.rb.

Related to #542966 (closed)

Verification

This scope was verified as unused by:

  • keela --type scopes flagged it as unused
  • Grep search found no callers in app/, lib/, ee/
  • Not used in scope chaining
  • Not used in merge() calls
  • Not used as default_scope, association scope, or via symbol/metaprogramming

The scope's referenced constant Packages::Nuget::TEMPORARY_PACKAGE_NAME remains in use elsewhere (for example lib/api/nuget_project_packages.rb), so it was left in place.

Cascade Removals

None - this was a standalone removal.

Metrics

Source File Complexity (flog)

Metric Before After Improvement
File flog total 34.3 30.3 -4.0 (11.7%)
Scope flog score 4.0 N/A -4.0 removed

Spec File Complexity (flog)

Metric Before After Improvement
Spec file flog total 276.2 255.3 -20.9 (7.6%)
Spec block flog score 20.9 N/A -20.9 removed

Test Suite Impact

  • Specs removed: 1 example
  • Spec file: spec/models/packages/nuget/package_spec.rb
  • Time saved per run: 2.58 seconds

Estimated CI Savings

Estimate Pipelines/Month Time Saved Cost Saved/Month Cost Saved/Year
Pessimistic 15,000 10.75 hrs/month $19.35 $232.20
Moderate 30,000 21.50 hrs/month $38.70 $464.40
Optimistic 50,000 35.83 hrs/month $64.50 $774.00

Based on 2.58 seconds saved per pipeline × $0.03/minute (large runners: 3x cost factor on $10/1000 base minutes)

Files Modified

  • app/models/packages/nuget/package.rb (scope removed - 2 lines)
  • spec/models/packages/nuget/package_spec.rb (specs removed - 11 lines, 1 example)
  • scripts/lint/keela_baseline.yml (entry removed - 2 lines)
  • Related to #542966 (closed) (Improve unused helper methods workflow)
  • Part of dead code cleanup effort
  • Scope was listed in scripts/lint/keela_baseline.yml

Merge request reports

Loading
Loading