Loading
Clean up whats_new_placement experiment
Summary
Productizes the winning variant of the whats_new_placement A/B experiment: the "What's new for you" item (compass icon) now always shows in the Profile/user menu, and the experiment scaffolding (experiment class, spec, feature flag definition, and the publish call in EE::SidebarsHelper) is removed.
Docs
doc/development/experiment_guide/testing_experiments.mdanddoc/development/internal_analytics/capturing_snowplow_events_in_specs.mdno longer name a live experiment; they use an illustrativemy_experimentname instead.spec/support_specs/helpers/snowplow_tracking_journey_spec.rbnow writes its own fixtures to a temp dir instead of loading real journeys, so future experiment cleanups don't need to touch it.- The
whats_new_placementjourney fixture underspec/fixtures/snowplow_tracking_journeys/is deleted rather than converted to a plain journey: every event it declared was experiment-only and is removed here, and the menu item click uses the genericclick_buttonevent, while opening the drawer fires the newopen_whats_new_drawerevent.
Behavior changes to note
- Self-managed users move from the Help menu item to the Profile menu item without ever having seen the experiment, since it only ran on GitLab.com.
- The drawer open event is now tracked as
open_whats_new_drawerinstead ofclick_whats_new_drawer; the WhatsNewUsage Tableau dashboard currently filters onclick_whats_new_drawerand will need to be updated toopen_whats_new_draweronce this ships. - Logged-out visitors have no user menu, so the Help menu still shows "What's new for you" for them (keyed off the existing
is_logged_insidebar flag). Signed-in users see it only in the Profile menu.
Validation steps
- On GDK, sign in.
- Open the Profile menu (click your avatar) and confirm "What's new for you" shows with the compass icon.
- Click it and confirm the What's new drawer opens.
- Open the
?Help menu and confirm "What's new for you" is not there while signed in. - Repeat steps 1-4 with
GITLAB_SIMULATE_SAAS=1set. - Sign out and confirm the Help menu shows "What's new for you" and clicking it opens the drawer.
- Optionally, using Snowplow Micro or the browser network tab, confirm
open_whats_new_drawerfires withproperty: profile_menuwhen signed in andproperty: help_menuwhen signed out, the menu item click firesclick_buttonwith labelwhats_new, and nowhats_new_placementexperiment context is attached.
What are the relevant issue numbers?
Edited by Roy Liu