Switch the branch names of the default merge requests factory
What does this MR do?
This MR simply changes the names of the source_branch
and target_branch
in the FactoryBot MergeRequest factory. Being much more typical that a merge request is opened from a feature bran ch and targets master to be merged into upon approval, having the names the other way around is a little counter-intuitive when debugging in specs.
Conformity
Changelog entryDocumentation (if required)-
Code review guidelines Merge request performance guidelines-
Style guides Database guidesSeparation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. Tested in all supported browsersInformed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- ~~Label as security and @ mention
@gitlab-com/gl-security/appsec
~~ The MR includes necessary changes to maintain consistency between UI, API, email, or other methodsSecurity reports checked/validated by a reviewer from the AppSec team
Edited by drew stachon