Fix omniauth_login_failed audit event streaming

Jio Castillorequested to merge
618809-omniauth_login_failed-audit-events-are-not-streamed-to-destinations into master

What does this MR do and why?

Fix omniauth_login_failed audit event streaming by utilizing the existing UnauthenticatedSecurityEventAuditor with some changes. Previously, events were not streaming because of a nil entity and would have also been dropped because determine_audit_model_entity/determine_from_entity_type would fail to do a user lookup.

References

Screenshots or screen recordings

Before After
image.png image.png

omniauth_login_failed

Before After
API - Non-existing user 
{
    "id": 1803,
    "author_id": -1,
    "entity_id": -1,
    "entity_type": "User",
    "event_name": "omniauth_login_failed",
    "details": {
        "failed_login": "LDAPMAIN",
        "author_name": "non-existing-user",
        "target_details": "non-existing-user",
        "event_name": "omniauth_login_failed",
        "author_class": "Gitlab::Audit::UnauthenticatedAuthor",
        "target_id": -1,
        "target_type": "User",
        "custom_message": "LDAPMAIN login failed",
        "ip_address": "127.0.0.1",
        "entity_path": null,
        "author_email": null
    },
    "created_at": "2026-09-11T22:09:43.322Z"
}
 
{
    "id": 1796,
    "author_id": -1,
    "entity_id": null,
    "entity_type": "Gitlab::Audit::InstanceScope",
    "event_name": "omniauth_login_failed",
    "details": {
        "failed_login": "LDAPMAIN",
        "event_name": "omniauth_login_failed",
        "author_name": "non-existing-user",
        "author_class": "Gitlab::Audit::UnauthenticatedAuthor",
        "target_id": -1,
        "target_type": "Gitlab::Audit::UnauthenticatedAuthor",
        "target_details": "non-existing-user",
        "custom_message": "LDAPMAIN login failed",
        "ip_address": "127.0.0.1",
        "entity_path": "gitlab_instance",
        "author_email": null
    },
    "created_at": "2026-09-11T21:51:52.749Z"
}
Stream - Non-existing user None 
{
    "id": 1796,
    "created_at": "2026-09-11T21:51:52.749Z",
    "author_id": -1,
    "target_id": -1,
    "event_name": "omniauth_login_failed",
    "details": {
        "failed_login": "LDAPMAIN",
        "event_name": "omniauth_login_failed",
        "author_name": "non-existing-user",
        "author_class": "Gitlab::Audit::UnauthenticatedAuthor",
        "target_id": -1,
        "target_type": "Gitlab::Audit::UnauthenticatedAuthor",
        "target_details": "non-existing-user",
        "custom_message": "LDAPMAIN login failed",
        "ip_address": "127.0.0.1",
        "entity_path": "gitlab_instance"
    },
    "ip_address": "127.0.0.1",
    "author_name": "non-existing-user",
    "entity_path": "gitlab_instance",
    "target_details": "non-existing-user",
    "target_type": "Gitlab::Audit::UnauthenticatedAuthor",
    "entity_type": "Gitlab::Audit::InstanceScope",
    "event_type": "omniauth_login_failed"
}
API Existing user 
{
    "id": 1804,
    "author_id": -1,
    "entity_id": -1,
    "entity_type": "User",
    "event_name": "omniauth_login_failed",
    "details": {
        "failed_login": "LDAPMAIN",
        "author_name": "test",
        "target_details": "test",
        "event_name": "omniauth_login_failed",
        "author_class": "Gitlab::Audit::UnauthenticatedAuthor",
        "target_id": -1,
        "target_type": "User",
        "custom_message": "LDAPMAIN login failed",
        "ip_address": "127.0.0.1",
        "entity_path": null,
        "author_email": null
    },
    "created_at": "2026-09-11T22:10:25.560Z"
}
 
{
    "id": 1798,
    "author_id": 70,
    "entity_id": 70,
    "entity_type": "User",
    "event_name": "omniauth_login_failed",
    "details": {
        "failed_login": "LDAPMAIN",
        "event_name": "omniauth_login_failed",
        "author_name": "Test",
        "author_class": "User",
        "target_id": 70,
        "target_type": "User",
        "target_details": "Test",
        "custom_message": "LDAPMAIN login failed",
        "ip_address": "127.0.0.1",
        "entity_path": "test",
        "author_email": "test@test.com"
    },
    "created_at": "2026-09-11T21:55:29.053Z"
}
Stream - Existing user None 
{
    "id": 1798,
    "created_at": "2026-09-11T21:55:29.053Z",
    "user_id": 70,
    "author_id": 70,
    "target_id": 70,
    "event_name": "omniauth_login_failed",
    "details": {
        "failed_login": "LDAPMAIN",
        "event_name": "omniauth_login_failed",
        "author_name": "Test",
        "author_class": "User",
        "target_id": 70,
        "target_type": "User",
        "target_details": "Test",
        "custom_message": "LDAPMAIN login failed",
        "ip_address": "127.0.0.1",
        "entity_path": "test"
    },
    "ip_address": "127.0.0.1",
    "author_name": "Test",
    "entity_path": "test",
    "target_details": "Test",
    "target_type": "User",
    "entity_id": 70,
    "entity_type": "User",
    "event_type": "omniauth_login_failed"
}

login_failed_with_standard_authentication (control - unchanged)

Before After
API - Non-existing user 
{
    "id": 1805,
    "author_id": -1,
    "entity_id": null,
    "entity_type": "Gitlab::Audit::InstanceScope",
    "event_name": "login_failed_with_standard_authentication",
    "details": {
        "failed_login": "STANDARD",
        "event_name": "login_failed_with_standard_authentication",
        "author_name": "non-existing-user",
        "author_class": "Gitlab::Audit::UnauthenticatedAuthor",
        "target_id": -1,
        "target_type": "Gitlab::Audit::UnauthenticatedAuthor",
        "target_details": "non-existing-user",
        "custom_message": "Failed to login with STANDARD authentication",
        "ip_address": "127.0.0.1",
        "entity_path": "gitlab_instance",
        "author_email": null
    },
    "created_at": "2026-09-11T22:11:10.159Z"
}
 
{
    "id": 1799,
    "author_id": -1,
    "entity_id": null,
    "entity_type": "Gitlab::Audit::InstanceScope",
    "event_name": "login_failed_with_standard_authentication",
    "details": {
        "failed_login": "STANDARD",
        "event_name": "login_failed_with_standard_authentication",
        "author_name": "non-existing-user",
        "author_class": "Gitlab::Audit::UnauthenticatedAuthor",
        "target_id": -1,
        "target_type": "Gitlab::Audit::UnauthenticatedAuthor",
        "target_details": "non-existing-user",
        "custom_message": "Failed to login with STANDARD authentication",
        "ip_address": "127.0.0.1",
        "entity_path": "gitlab_instance",
        "author_email": null
    },
    "created_at": "2026-09-11T21:59:06.058Z"
}
Stream - Non-existing user 
{
    "id": 1805,
    "created_at": "2026-09-11T22:11:10.159Z",
    "author_id": -1,
    "target_id": -1,
    "event_name": "login_failed_with_standard_authentication",
    "details": {
        "failed_login": "STANDARD",
        "event_name": "login_failed_with_standard_authentication",
        "author_name": "non-existing-user",
        "author_class": "Gitlab::Audit::UnauthenticatedAuthor",
        "target_id": -1,
        "target_type": "Gitlab::Audit::UnauthenticatedAuthor",
        "target_details": "non-existing-user",
        "custom_message": "Failed to login with STANDARD authentication",
        "ip_address": "127.0.0.1",
        "entity_path": "gitlab_instance"
    },
    "ip_address": "127.0.0.1",
    "author_name": "non-existing-user",
    "entity_path": "gitlab_instance",
    "target_details": "non-existing-user",
    "target_type": "Gitlab::Audit::UnauthenticatedAuthor",
    "entity_type": "Gitlab::Audit::InstanceScope",
    "event_type": "login_failed_with_standard_authentication"
}
 
{
    "id": 1799,
    "created_at": "2026-09-11T21:59:06.058Z",
    "author_id": -1,
    "target_id": -1,
    "event_name": "login_failed_with_standard_authentication",
    "details": {
        "failed_login": "STANDARD",
        "event_name": "login_failed_with_standard_authentication",
        "author_name": "non-existing-user",
        "author_class": "Gitlab::Audit::UnauthenticatedAuthor",
        "target_id": -1,
        "target_type": "Gitlab::Audit::UnauthenticatedAuthor",
        "target_details": "non-existing-user",
        "custom_message": "Failed to login with STANDARD authentication",
        "ip_address": "127.0.0.1",
        "entity_path": "gitlab_instance"
    },
    "ip_address": "127.0.0.1",
    "author_name": "non-existing-user",
    "entity_path": "gitlab_instance",
    "target_details": "non-existing-user",
    "target_type": "Gitlab::Audit::UnauthenticatedAuthor",
    "entity_type": "Gitlab::Audit::InstanceScope",
    "event_type": "login_failed_with_standard_authentication"
}
API - Existing user 
{
    "id": 1806,
    "author_id": 70,
    "entity_id": 70,
    "entity_type": "User",
    "event_name": "login_failed_with_standard_authentication",
    "details": {
        "failed_login": "STANDARD",
        "event_name": "login_failed_with_standard_authentication",
        "author_name": "Test",
        "author_class": "User",
        "target_id": 70,
        "target_type": "User",
        "target_details": "Test",
        "custom_message": "Failed to login with STANDARD authentication",
        "ip_address": "127.0.0.1",
        "entity_path": "test",
        "author_email": "test@test.com"
    },
    "created_at": "2026-09-11T22:12:14.402Z"
}
 
{
    "id": 1800,
    "author_id": 70,
    "entity_id": 70,
    "entity_type": "User",
    "event_name": "login_failed_with_standard_authentication",
    "details": {
        "failed_login": "STANDARD",
        "event_name": "login_failed_with_standard_authentication",
        "author_name": "Test",
        "author_class": "User",
        "target_id": 70,
        "target_type": "User",
        "target_details": "Test",
        "custom_message": "Failed to login with STANDARD authentication",
        "ip_address": "127.0.0.1",
        "entity_path": "test",
        "author_email": "test@test.com"
    },
    "created_at": "2026-09-11T22:01:33.362Z"
}
Stream - Existing user 
{
    "id": 1806,
    "created_at": "2026-09-11T22:12:14.402Z",
    "user_id": 70,
    "author_id": 70,
    "target_id": 70,
    "event_name": "login_failed_with_standard_authentication",
    "details": {
        "failed_login": "STANDARD",
        "event_name": "login_failed_with_standard_authentication",
        "author_name": "Test",
        "author_class": "User",
        "target_id": 70,
        "target_type": "User",
        "target_details": "Test",
        "custom_message": "Failed to login with STANDARD authentication",
        "ip_address": "127.0.0.1",
        "entity_path": "test"
    },
    "ip_address": "127.0.0.1",
    "author_name": "Test",
    "entity_path": "test",
    "target_details": "Test",
    "target_type": "User",
    "entity_id": 70,
    "entity_type": "User",
    "event_type": "login_failed_with_standard_authentication"
}
 
{
    "id": 1800,
    "created_at": "2026-09-11T22:01:33.362Z",
    "user_id": 70,
    "author_id": 70,
    "target_id": 70,
    "event_name": "login_failed_with_standard_authentication",
    "details": {
        "failed_login": "STANDARD",
        "event_name": "login_failed_with_standard_authentication",
        "author_name": "Test",
        "author_class": "User",
        "target_id": 70,
        "target_type": "User",
        "target_details": "Test",
        "custom_message": "Failed to login with STANDARD authentication",
        "ip_address": "127.0.0.1",
        "entity_path": "test"
    },
    "ip_address": "127.0.0.1",
    "author_name": "Test",
    "entity_path": "test",
    "target_details": "Test",
    "target_type": "User",
    "entity_id": 70,
    "entity_type": "User",
    "event_type": "login_failed_with_standard_authentication"
}

How to set up and validate locally

  1. Enable LDAP
  2. Add a new HTTP destination
  3. In a private browser, initiate a failed LDAP login
  4. Observe that:
    • DB Audit events capture the event successfully
    • Streaming destinations now receive the event, previously they did not.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #618809 (closed)

Edited by Jio Castillo

Merge request reports