Skip to content

GitLab Next

    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Menu
    Projects Groups Snippets
  • Get a free trial
  • Sign up
  • Login
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 42,635
    • Issues 42,635
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,398
    • Merge requests 1,398
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

GitLab 15.0 is launching on May 22! This version brings many exciting improvements, but also removes deprecated features and introduces breaking changes that may impact your workflow. To see what is being deprecated and removed, please visit Breaking changes in 15.0 and Deprecations.

  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !2551
Project 'gitlab-org/gitlab-ee' was moved to 'gitlab-org/gitlab'. Please update any links and bookmarks that may still have the old path.
Merged
Created Jul 28, 2017 by Nick Thomas@nick.thomas🔴Contributor19 of 21 tasks completed19/21 tasks
  • Review changes

  • Download
  • Email patches
  • Plain diff

Resolve "Pull repository mirroring: Support for SSH keys"

  • Overview 170
  • Commits 5
  • Pipelines 59
  • Changes 48

What does this MR do?

Introduces SSH public-key authentication to pull mirroring.

Tasks:

  • Configuration backend (username/password auth)
  • Configuration backend (public-key auth)
  • Configuration frontend (wireframe)
  • Configuration frontend (complete) https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2550
  • SSH known_hosts file generator (backend)
  • SSH host key fingerprint verification (backend)
  • SSH host key fingerprint verification (frontend) https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2550
  • gitlab-shell.fetch_remote updated to support pubkey auth
  • gitlab-shell#95 (closed)
  • Comprehensive test coverage. Pull mirroring seems to be mostly untested at the moment
  • Documentation!
  • Backports to CE https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13275

Are there points in the code the reviewer needs to double check?

The import_url and project_import_data data is shared with CE, so we need to pay attention to backports when refactoring.

Why was this MR needed?

Scheduled feature for %9.5

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if it does - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

Closes #98 (closed) https://gitlab.com/gitlab-org/gitlab-ce/issues/21391

Edited Aug 07, 2017 by Nick Thomas
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 98-pull-mirror-ssh-keys-2