Skip to content

Fix inline error display when creating a custom stage

What does this MR do?

  • Ensure we show inline form errors when creating a custom stage
  • Ensure default stage names can not be used for custom stages

Related to #35823 (closed), #36685 (closed)

Screenshots

Before After
Screen_Shot_2020-02-25_at_7.42.57_am Screen_Shot_2020-02-25_at_7.38.54_am

Feature flags

Requires the :customizable_cycle_analytics feature flag to be enabled

Testing

You will need to have the :customizable_cycle_analytics feature flag enabled

  1. Navigate to http://localhost:3001/-/analytics/value_stream_analytics
  2. Select a group
  3. Click the Add a stage button
  4. Fill out the fields, but use issue (lowercase) in the name field
  5. Click submit, the backend will return a 422 error, and a message should appear underneath the name field
  6. Change the name to something of your choosing, then submit again
  7. The new stage should be persisted

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports