Loading
Allow opening overflowed saved views in a new tab
What does this MR do and why?
On the work items list, saved views show as tabs in the header, and any views that don't fit collapse into an dropdown menu. The visible tabs are real links, so right-click "Open link in new tab", Cmd/Ctrl+click and middle-click all work to open a view in a new tab. The items inside the dropdown menu only had an action callback, so GitLab UI rendered them as plain buttons with no URL, and none of those ways to open a view in a new tab worked there. This MR basically targets to fix opening the item in new tab or window.
References
Closes #623578 (closed)
Screenshots or screen recordings
How to set up and validate locally
- Open a group or project work items list, for example
http://127.0.0.1:3000/groups/gitlab-org/-/work_items. - Create enough saved views that some collapse into the dropdown menu.
- Narrow the browser window until the menu appears.
- Open dropdown and right-click a view. "Open link in new tab" should be available and should open that view.
- Cmd/Ctrl+click or middle-click a view in the menu. It opens in a new tab and the current tab does not change, no navigation and no change in tab order.
- Left-click a view in the menu. It switches to that view in the same tab without a full page reload, the view moves into the header tabs, and the order stays the same after a refresh.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Rajan Mistry