Refactored deploy keys to cicd settings

What does this MR do?

Refactored deploy keys to cicd settings

Screenshots

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

Closes #199370 (closed)

changed milestone to %12.9

added Category:Continuous Delivery deploy keys devopsrelease [DEPRECATED] grouprelease [DEPRECATED] workflowin dev labels

	2 Warnings
	This merge request changed files with disabled eslint rules. Please consider fixing them.
	675b89b9: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body

	1 Message
	This merge request adds or changes files that require a review from the Database team.

Disabled eslint rules

The following files have disabled eslint rules. Please consider fixing them:

• app/assets/javascripts/pages/projects/settings/repository/form.js

Run the following command for more details

node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \
  'app/assets/javascripts/pages/projects/settings/repository/form.js'

This merge request requires a database review. To make sure these changes are reviewed, take the following steps:

1. Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
2. Prepare your MR for database review according to the docs.
3. Assign and mention the database reviewer suggested by Reviewer Roulette.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
frontend	Ragnar Hardarson (@rhardarson)	Fatih Acet (@fatihacet)
backend	Tyler Amos (@tyleramos)	Ash McKenzie (@ashmckenzie)
test Quality for spec/features/*	No reviewer available	No maintainer available
database	Alper Akgun (@a_akgun)	Andreas Brandl (@abrandl)

Generated by Danger

added 103 commits

• 0186ae6a...c299e39f - 100 commits from branch master
• ef884b46 - Refactored deploy keys to cicd settings
• 40ad45b6 - Added changelog file
• 9d6d8608 - Updated Deploy Keys rspecs.

Compare with previous version

added 32 commits

• 9d6d8608...5f7da728 - 28 commits from branch master
• 463121e0 - Refactored deploy keys to cicd settings
• 777170d3 - Added changelog file
• aeb99700 - Updated Deploy Keys rspecs.
• 8a5c4491 - Moved deploy keys scripts to cicd settings form

Compare with previous version

added 2 commits

• 995a15cd - Updated Deploy Keys rspecs
• 0e8a2292 - Moved deploy keys scripts to cicd settings form

Compare with previous version

added typefeature label

added 83 commits

• 0e8a2292...d97df434 - 79 commits from branch master
• 590345a6 - Refactored deploy keys to cicd settings
• 84773ffd - Added changelog file
• 26e498dc - Updated Deploy Keys rspecs
• bec7c4c2 - Moved deploy keys scripts to cicd settings form

Compare with previous version

added documentation label

@nkipling @aakriti.gupta Can you please review this MR as frontend and backend reviewers?

@marcia There is a tiny change in documentation in this MR. Can you please review it?

assigned to @marcia, @nkipling, and @aakriti.gupta and unassigned @ebaque

added workflowin review label and removed workflowin dev label

approved this merge request

unassigned @nkipling

assigned to @ntepluhina

approved this merge request

Backend LGTM!

unassigned @aakriti.gupta

frontend LGTM

approved this merge request

assigned to @aakriti.gupta and unassigned @ntepluhina

assigned to @ifarkas and unassigned @aakriti.gupta

assigned to @aakriti.gupta and unassigned @ifarkas

assigned to @ifarkas and unassigned @aakriti.gupta

Thanks @ebaque! Looks good, just a few minor comments / questions.

assigned to @ebaque and unassigned @ifarkas

added 184 commits

• bec7c4c2...eb3770c9 - 180 commits from branch master
• 6ff55cef - Refactored deploy keys to cicd settings
• 1cce5a7c - Added changelog file
• c6ecfd47 - Updated Deploy Keys rspecs
• 034acc08 - Moved deploy keys scripts to cicd settings form

Compare with previous version

added 16 commits

• 034acc08...e4e4fba0 - 12 commits from branch master
• ec3ea107 - Refactored deploy keys to cicd settings
• d931540c - Added changelog file
• 77608d0b - Updated Deploy Keys rspecs
• 9a1155ce - Moved deploy keys scripts to cicd settings form

Compare with previous version

mentioned in issue #198691 (closed)

assigned to @ifarkas

added 67 commits

• 9a1155ce...dea8d7de - 63 commits from branch master
• e61a5e1c - Refactored deploy keys to cicd settings
• d96633c3 - Added changelog file
• 3367e339 - Updated Deploy Keys rspecs
• d776061a - Moved deploy keys scripts to cicd settings form

Compare with previous version

approved this merge request

unassigned @ifarkas

assigned to @eread and @axil and unassigned @marcia and @ebaque

assigned to @ebaque and unassigned @axil and @eread

added 387 commits

• d776061a...d5ceeeb2 - 382 commits from branch master
• 031a77ab - Refactored deploy keys to cicd settings
• 40a588fc - Added changelog file
• b6a0e864 - Updated Deploy Keys rspecs
• 4b339b73 - Moved deploy keys scripts to cicd settings form
• 143cd411 - Added some documentation based on review

Compare with previous version

added 1 commit

• eaf92099 - Added some documentation based on review

Compare with previous version

assigned to @eread and unassigned @ebaque

added 1 commit

• 76e4ec17 - Added some documentation based on review

Compare with previous version

approved this merge request

assigned to @ebaque and unassigned @eread

added 195 commits

• 76e4ec17...2b3ac7af - 190 commits from branch master
• 6536a5d2 - Refactored deploy keys to cicd settings
• d2be728d - Added changelog file
• 548dba9d - Updated Deploy Keys rspecs
• b96825b2 - Moved deploy keys scripts to cicd settings form
• fdc3755a - Added some documentation based on review

Compare with previous version

assigned to @eread and unassigned @ebaque

assigned to @ifarkas

unassigned @eread

resolved all threads

enabled an automatic merge when the pipeline for 4650a89e succeeds

added database databasereview pending labels

resolved all threads

canceled the automatic merge

assigned to @ebaque and unassigned @ifarkas

added 396 commits

• fdc3755a...150f788f - 391 commits from branch master
• 2568cf9a - Refactored deploy keys to cicd settings
• 68f6ecfc - Added changelog file
• 444e7e26 - Updated Deploy Keys rspecs
• b8e60a82 - Moved deploy keys scripts to cicd settings form
• a81e7c4f - Added some documentation based on review

Compare with previous version

added 1 commit

• a9efee9e - Added some documentation based on review

Compare with previous version

added 1 commit

• a08997fb - Added some documentation based on review

Compare with previous version

added 31 commits

• a08997fb...42f58bb3 - 26 commits from branch master
• 08d39e45 - Refactored deploy keys to cicd settings
• 25ecb604 - Added changelog file
• 9c573b2e - Updated Deploy Keys rspecs
• 56f2dc31 - Moved deploy keys scripts to cicd settings form
• 365739d9 - Added some documentation based on review

Compare with previous version

added 1 commit

• 675b89b9 - Added some documentation based on review

Compare with previous version

assigned to @ifarkas and unassigned @ebaque

resolved all threads

merged

mentioned in commit 0c01178c

mentioned in issue gitlab-com/www-gitlab-com#4878 (closed)

mentioned in issue #208761 (closed)

We have some end-to-end tests that are failing because they're still looking for deploy keys in the old location. @ebaque - Would you mind updating them to reflect this change? Details in #208761 (closed) .

Thanks for letting me know about this @jo_shih? I'll submit a MR soon.

How did I miss that? The QA pipeline triggered a few errors a while back which I fixed, but then it was all green.

added workflowstaging label and removed workflowin review label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

mentioned in merge request !27465 (merged)

mentioned in issue #212775 (closed)

mentioned in merge request !29184 (merged)

mentioned in issue #214263 (closed)

mentioned in merge request !30669 (merged)