Remove unused constant Projects::CommitController::BRANCH_SEARCH_LIMIT

Kerri Millerrequested to merge
542966-remove-unused-branch-search-limit-constant into master

Summary

Removes the unused constant Projects::CommitController::BRANCH_SEARCH_LIMIT from app/controllers/projects/commit_controller.rb.

Related to #542966

Verification

This constant was verified as unused by:

  • keela --type constants flagged it as unused (listed in scripts/lint/keela_baseline.yml)
  • Grep search found no callers (only reference in the codebase was the definition itself)
  • No metaprogramming patterns reference it (const_get, const_defined?, :BRANCH_SEARCH_LIMIT, string references)
  • Not part of a configuration or environment check
  • No spec references the constant (searched spec/ for BRANCH_SEARCH_LIMIT)

Cascade Removals

None - this was a standalone removal.

Metrics

Source File Complexity (flog)

Metric Before After Improvement
File flog total 430.8 430.8 0.0 (0%)
Constant flog score 0.0 N/A 0.0 removed (bare assignment, no method complexity)

Spec File Complexity (flog)

Metric Before After Improvement
Spec file flog total N/A N/A 0.0 (no spec references this constant)
Spec block flog score N/A N/A 0.0 removed

Combined Flog Summary

File Flog Removed
app/controllers/projects/commit_controller.rb 0.0
(no spec file) 0.0
Total 0.0

Test Suite Impact

  • Specs removed: 0 examples (constant was untested)
  • Spec file: none
  • Time saved per run: 0.00 seconds

Estimated CI Savings

Estimate Pipelines/Month Time Saved Cost Saved/Month Cost Saved/Year
Pessimistic 15,000 0.00 hrs/month $0.00 $0.00
Moderate 30,000 0.00 hrs/month $0.00 $0.00
Optimistic 50,000 0.00 hrs/month $0.00 $0.00

Based on 0.00 seconds saved per pipeline × $0.03/minute (large runners: 3x cost factor on $10/1000 base minutes). This constant had no test coverage, so there is no direct spec-time CI savings; the benefit is reduced dead code and maintenance surface.

Files Modified

  • app/controllers/projects/commit_controller.rb (constant removed - 1 line)
  • scripts/lint/keela_baseline.yml (entry removed - 2 lines)

Related

  • Related to #542966 (Improve unused helper methods workflow)
  • Part of dead code cleanup effort
  • Constant was listed in scripts/lint/keela_baseline.yml

Merge request reports