Skip to content

Fix disappearing tags list on modal in container registry

What does this MR do?

This MR fixes the 'truncated' container registry list when the delete modal is open.

This is achieved by assigning position-absolute only during the animation and not permanently.

The issue was that the modal adds: overflow: hidden to the body effectively hiding the absolutely positioned list

Screenshots

page before after
List Screenshot_2020-02-18_at_11.33.18 Screenshot_2020-02-18_at_11.30.22
Details Screenshot_2020-02-18_at_11.32.49 Screenshot_2020-02-18_at_11.30.37

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #205410 (closed)

Edited by Yorick Peterse

Merge request reports