Edit new JupyterHub content
What does this MR do?
Closes: #205393 (closed).
A follow up edit of the content added in !24754 (merged).
WDYT, @ashmckenzie @proglottis?
If these changes look ok to you, I'll forward to @marcel.amirault for review and merge.
Thanks!
Author's checklist
-
Follow the Documentation Guidelines and Style Guide. -
If applicable, update the permissions table. -
Link docs to and from the higher-level index page, plus other related docs where helpful. -
Apply the documentation label.
Review checklist
All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.
1. Primary Reviewer
-
Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.
2. Technical Writer
-
Optional: Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage.
3. Maintainer
-
Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review. -
Ensure a release milestone is set. -
If there has not been a technical writer review, create an issue for one using the Doc Review template.
Merge request reports
Activity
changed milestone to %12.9
- Resolved by Ash McKenzie
- Resolved by Evan Read
Looking good @eread, just two suggestions
I'm no JupyterHub expert so I will defer to @proglottis for the specificsEdited by Ash McKenzieunassigned @ashmckenzie
This all makes sense to me @eread - Thanks!
assigned to @eread and unassigned @proglottis
added 1073 commits
-
3f23b89f...af8f0bdd - 1071 commits from branch
master
- a0061fb5 - Edit new JupyterHub content
- ce2a2e65 - Implement review comments
-
3f23b89f...af8f0bdd - 1071 commits from branch
assigned to @marcel.amirault
unassigned @eread
- Resolved by Marcel Amirault
mentioned in issue #208399 (closed)
@eread Everything looked good, but some of the old content was confusing, or not using SSOT guidelines. I raised an issue to review that content later. For now though, this is definitely better!
mentioned in commit 236af548
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added groupenvironments label and removed groupconfigure [DEPRECATED] label