Skip to content
Snippets Groups Projects

Edit new JupyterHub content

Merged Evan Read requested to merge eread/edit-jupyterhub-ci-content into master
All threads resolved!

What does this MR do?

Closes: #205393 (closed).

A follow up edit of the content added in !24754 (merged).

WDYT, @ashmckenzie @proglottis?

If these changes look ok to you, I'll forward to @marcel.amirault for review and merge.

Thanks!

Author's checklist

Review checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.

1. Primary Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

2. Technical Writer

  • Optional: Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage.

3. Maintainer

  1. Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  2. Ensure a release milestone is set.
  3. If there has not been a technical writer review, create an issue for one using the Doc Review template.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ash McKenzie
  • Looking good @eread, just two suggestions :slight_smile: I'm no JupyterHub expert so I will defer to @proglottis for the specifics :slight_smile: :ping_pong:

    Edited by Ash McKenzie
  • James Fargher approved this merge request

    approved this merge request

  • This all makes sense to me @eread - Thanks!

  • James Fargher assigned to @eread and unassigned @proglottis

    assigned to @eread and unassigned @proglottis

  • Evan Read added 1073 commits

    added 1073 commits

    Compare with previous version

  • Evan Read resolved all threads

    resolved all threads

  • unassigned @eread

  • Marcel Amirault
  • Marcel Amirault resolved all threads

    resolved all threads

  • mentioned in issue #208399 (closed)

  • Marcel Amirault approved this merge request

    approved this merge request

  • @eread Everything looked good, but some of the old content was confusing, or not using SSOT guidelines. I raised an issue to review that content later. For now though, this is definitely better! :rocket:

  • Marcel Amirault mentioned in commit 236af548

    mentioned in commit 236af548

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading