Skip to content

Disable self-approval at the Instance level - Fix approvals filtering

What does this MR do?

While checking !23731 (merged) I've noticed some inconsistencies in the behaviour in the app - some places were using name of the method without question mark, which was changed in the original MR, and some with.

I've added aliasing it so it is now consistent. Added some specs as well.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #39060 (closed)

Merge request reports