Backport of 'Fix empty partition range crashing pipeline lookups (CI outage)' to 19-1
What does this MR do and why?
Backport of !253802 (merged).
Ci::Partitions::SyncService wrote an exclusive range (min...max) into
ci_partitions.pipelines_id_range (an int8range column). When a switching
partition held exactly one pipeline (min == max), that range was empty and
PostgreSQL stored it as 'empty'. PartitionCache#load_from_database only
filtered SQL NULL, so the empty row loaded, ActiveRecord cast it to nil,
and PartitionCache#store then called nil.begin, raising NoMethodError.
This runs inside Ci::Pipeline.find_by_id, so every Sidekiq worker that looks
up a pipeline crashed. New pipelines stayed in created and jobs were never
sent to runners, an instance-wide CI outage.
The fix uses inclusive ranges (min..max and (max.next..)) so a
single-pipeline range is never empty and the max pipeline is not dropped
into a gap, and it skips empty ranges when loading the cache
(NOT isempty(pipelines_id_range)) to guard against any already-persisted
empty range.
Fixes #608165 (closed)
This is a clean cherry-pick of the single fix commit. On 19-1-stable-ee the
spec base differs slightly (let_it_be(..., freeze: false) versus
let_it_be_with_reload), which the patch does not touch; the applied change is
identical to the default-branch MR.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
- This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
- The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
- The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
- Required labels have been applied to this merge request
- severity label and bug subtype labels (if applicable)
- If this MR fixes a bug that affects customers, the customer label has been applied.
- This MR has been approved by a maintainer (only one approval is required).
- Ensure the
e2e:test-on-omnibus-eejob has succeeded, or if it has failed, investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releasesSlack channel (internal only). - Once the backport has been merged, the commit changes will be automatically deployed to a release environment that can be used for manual validation. See after merging runbook for details.