Backport 'Stop resetting mcp_server_enabled when Duo settings change' to 19-3-stable-ee

What does this MR do and why?

Backport of "Stop resetting mcp_server_enabled when Duo settings change" (!253505 (merged)) to the 19.3 stable branch.

Removes the sync_mcp_server_enabled before_save callback from EE::NamespaceSetting. Since GitLab 19.2, MCP server access is governed by the dedicated mcp_server_enabled setting. However, this callback still recomputed the root-group setting as duo_features_enabled && experiment_features_enabled whenever either of those was saved, so a group Owner who had explicitly enabled MCP access could have it silently turned off by changing Duo availability or beta/experimental features.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
  • Required labels have been applied to this merge request
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:test-on-omnibus-ee job has succeeded, or if it has failed, investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Sebastian Rehm

Merge request reports

Loading
Loading