Bump gitlab-shell to 14.57.1

Vladimir Glafirovrequested to merge
vg/bump-gitlab-shell-14-57-1 into master

What does this MR do and why?

Bumps GITLAB_SHELL_VERSION from 14.57.0 to 14.57.1 to ship gitlab-shell!1541 (merged).

-14.57.0
+14.57.1

⚠️ Draft: blocked on the v14.57.1 tag

Do not merge until [gitlab-org/gitlab-shell] has tagged v14.57.1. As of writing, the release MR (gitlab-shell!1543 (merged)) is merged and VERSION on main reads 14.57.1, but the tag itself does not exist yet:

$ git tag --sort=-creatordate | head -2
v14.57.0
v14.56.1

$ git rev-parse v14.57.1
-> unknown revision

Merging before the tag exists would point CNG at a non-existent ref and break the build. Ready to merge as soon as the tag is pushed.

What this fixes

Every Topology Service Classify call from GitLab Shell fails:

rpc error: code = InvalidArgument desc = invalid type: "UNSPECIFIED"

The Topology Service removed the singular claim request field (reserved 4) in favor of a repeated claims fallback chain, but GitLab Shell still populated the removed field. The server therefore decoded an effectively empty request, fell through to type/value classification with an unset type, and rejected it.

The failure is silent: the resolver catches the error and falls back to the default host, so Git-over-SSH keeps working and pods stay healthy. Only gitlab_shell_topology_requests_total{status="fail"} and the logs reveal it — meaning the Topology Service integration is effectively a no-op wherever it is enabled.

Why the version bump is required

CNG builds GitLab Shell from this pinned version, not from main, so the fix cannot reach any deployment without it. Verified on the GitLab.com staging canary (gstg-cny), which runs an image built ~17h after !1541 (merged) merged and still fails:

gitlab_shell_topology_requests_total{status="fail"}   2 / 4   (per pod)
gitlab_shell_topology_requests_total{status="ok"}     absent — never incremented
gitlab_shell_topology_request_duration_seconds_count  0

(connections_total{status="ok"} 1 — the gRPC channel and mTLS are healthy; only the request content is rejected.)

Contents of 14.57.1

One change since v14.57.0:

Risk

Low. A single-line version bump carrying one upstream commit that only touches internal/topology, plus a regression test. topology_service is opt-in and disabled by default, so instances without it are unaffected; those with it enabled go from 100% Classify failures to working requests.

Upstream verification: 49 packages passing, make lint clean, and the new regression test confirmed failing without the client change.

Related

MR acceptance checklist

  • Bumps a single pinned dependency version; no application code changes.
  • Upstream release contents documented above.
  • Blocked: v14.57.1 tag must exist in gitlab-org/gitlab-shell before merge.

/cc @vyaklushin @igor.drozdov

Edited by Vasilii Iakliushin

Merge request reports