Skip to content

Clean up conditional `col-` classes in `nav_dropdown_button.vue`

David O'Regan requested to merge oregand/gitlab:205435 into master

What does this MR do?

This merge is for issue #205435 (closed)

In this merge we are trying to clean up the conditional col- classes inside nav_dropdown_button.vue by leveraging a flex based approach.

Screenshots

  • MRs not allowed
Before After
Screenshot_2020-02-18_17-32-56 Screenshot_2020-02-18_17-36-46
Screenshot_2020-02-18_17-34-54 Screenshot_2020-02-18_17-37-45
  • MRs Allowed
Before After
Screenshot_2020-02-19_16-17-57 Screenshot_2020-02-19_16-19-15
Screenshot_2020-02-19_16-18-15 Screenshot_2020-02-19_16-19-28

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by David O'Regan

Merge request reports