Don't raise BridgeStatusError
What does this MR do?
Related to: #205705 (closed)
This fixes a bug that was found on staging while testing child-parent pipelines. For some reasons (still to be investigated) a bridge job could be in non pending state while we try to call pipeline.update_bridge_status!. This call raises Ci::Pipeline::BridgeStatusError if the bridge is not in any active state.
Raising this error caused the Ci::CreateCrossProjectPipelineWorker to retry the operation, causing duplicate child pipelines.
Screenshots
https://gitlab.com/gitlab-org/gitlab/uploads/db8909a8f9429647908b9625c1d7c1fc/image.png
https://gitlab.com/gitlab-org/gitlab/uploads/9744fbcb8caeef60de53fb8e00cfeb04/image.png
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team