Loading
Add scan profile drawer to scanners overview
What does this MR do and why?
Add scan profile drawer to scanners overview
Add a tertiary Manage profiles button to the actions column of the
group scanners overview secret detection row, and a blank ScanProfileDrawer that it opens
Gate the button and the drawer behind the
custom_secret_detection_profiles_ui feature flag
Also adjust the table style (regardless of feature flag state):
- Give the three columns equal thirds
- Round the corners of the table header
- Separate the rows with gray lines
- Lighten the scanner name to semibold
- Move the info icon in ScanTypeCell inside the scanner name, so it
trails the last line when the name wraps
- Restore the row separators gitlab-ui already draws on GlTable cells
Related to https://gitlab.com/gitlab-org/gitlab/-/work_items/624191References
- issue: [Frontend] Scan profile drawer: view, create, e... (#624191)
- implementation plan in the epic: gitlab-org#20198 (comment 3745722841)
- designs: Design: Scanner Enablement Wizard (#593900)
- prototype: https://security-coverage-prototype-0b2bbb.gitlab.io/security-inventory-profiles/#/security-configuration
Screenshots or screen recordings
| Before | After |
|---|---|
![]() |
![]() |
![]() |
How to set up and validate locally
-
git checkout 624191-add-scan-profile-drawer-to-scanners-overview echo "Feature.enable(:custom_secret_detection_profiles_ui)" | gdk rails c - have a GitLab Ultimate licence
- go to a group =>
Secure=>Security configuration=>Scanners - check that the secret detection row of the scanners table:
- shows
Manage profilesas a borderless button, left ofView details
- shows
- click
Manage profiles - check that a drawer opens:
- titled
Manage <scanner> profiles, naming the scanner whose row you clicked
- titled
table styling, which is not behind the flag
-
echo "Feature.disable(:custom_secret_detection_profiles_ui)" | gdk rails c - reload
Secure=>Security configuration=>Scanners - check that
Manage profilesis gone and the rest of the table is intact:Scanner,Project coverageand the actions column each take a third of the table width, so the two column boundaries sit at even thirds- a gray line separates each row from the next, running the full table width including the actions column
- there should be no line under the last row, and none under the header
- the gray header block has rounded corners at the bottom as well as the top
- check that the scanner name in each row:
- reads slightly lighter than the previous bold, still clearly bolder than body text
- carries its
iicon immediately after the name, not out at the column edge
- narrow the browser until a long scanner name such as
Static application security testing (SAST)wraps onto two lines - check that the
iicon:- follows the last word of the wrapped name rather than sitting at the right edge of the column
- keeps its full size rather than being squashed
to run tests
yarn jest ee/spec/frontend/security_configuration/components/scan_profilesbundle exec rspec ee/spec/requests/groups/security/configuration_controller_spec.rbMR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #624191
Edited by Miranda Fluharty



