Remove stale keela exclusions

Kerri Millerrequested to merge
kerrizor/remove-stale-keela-exclusions into master

Summary

Removes three stale entries from scripts/lint/keela_excluded.yml. Each referenced a method that no longer exists in the codebase, so the exclusion was dead weight.

Verification

Found via keela --test-exclusions, which validates that every entry in the exclusion file matches an actual definition:

⚠️  Stale exclusions found (3):
   methods:
     app/models/ci/catalog/components_project.rb:fetch_component — no definition found
     ee/app/models/ai/catalog/item.rb:starred_by? — no definition found
     ee/app/models/ai/duo_workflows/workflow.rb:reconstruct_from_blobs? — no definition found

Confirmed each method has no definition anywhere in app/, ee/, or lib/ via git grep "def <name>".

The latter two were speculative exclusions added for follow-up work that never landed in the referenced shape.

After the change:

  • keela --test-exclusions: All exclusions are valid! (66 valid, 0 stale)
  • keela (baseline check): exits 0, baseline consistent
  • The ee/app/models/ai/duo_workflows/workflow.rb block is preserved with its three still-valid exclusions (checkpoint_header_for, latest_checkpoint_header, reconstructed_channel_values)

Files Modified

  • scripts/lint/keela_excluded.yml (3 stale method exclusions + 2 now-empty file headers removed - 5 lines)

Related

  • Part of dead code cleanup effort
  • Keeps the keela exclusion file in sync with the code

Merge request reports