Skip to content

Fix autocomplete limitation bug

Lukas 'ai-pi' Eipert requested to merge leipert-fix-user-label-bug into master

What does this MR do?

Fix autocomplete limitation bug

jQuery at.js has a hard limit on how many items can be searched. Before it executes it's search function, it limits the array size to 1000 items. We have been hitting this bug because we have more than a thousand users or labels 0 1.

We are planning to replace at.js 2, but in order to fix this bug for now, we have forked at.js 3 and made adjustments, so that it works for our usecases.

Performance wise this should have no big impact, as we are rendering a maximum of 5 results in the most cases anyway. The search on the javascript side is rather performant.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas 'ai-pi' Eipert

Merge request reports