Remove custom_roles_for_protected_branches feature flag

Joe Woodwardrequested to merge
duo/feature/594891-remove-custom-roles-for-protected-branches-flag into master

What does this MR do and why?

Removes the custom_roles_for_protected_branches feature flag, which has been fully rolled out. This keeps only the enabled codepath by:

  • Deleting ee/config/feature_flags/wip/custom_roles_for_protected_branches.yml
  • Removing the custom_roles_for_protected_branches_enabled? helper methods from EE::ProtectedBranchAccess and EE::Groups::Settings::RepositoryController, inlining the license check (group.licensed_feature_available?(:custom_roles)) directly
  • Removing the feature flag check from EE::API::Entities::ProtectedRefAccess and EE::Projects::Settings::BranchRulesHelper
  • Removing all stub_feature_flags(custom_roles_for_protected_branches: ...) calls and their surrounding disabled-state context blocks from specs
  • Updating API docs version history entries to drop the feature flag note

References

Edited by Joe Woodward

Merge request reports