Skip to content

Migrate '.fa-spinner' to '.spinner' for 'app/assets/javascripts/vue_shared/components/markdown/toolbar.vue'

What does this MR do?

Migrated the markdown attachment spinner form 'fa fa-spinner fa-spin' to 'spinner'

Screenshots

Before

Screenshot_2020-02-12_at_22.47.46

After

Screenshot_2020-02-12_at_22.49.37

Before After
before_-_fa_fa-spinner after_-_spinner

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

No style changes were applied, just a reference updated to the new spinner

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #202274 (closed)

Edited by Brandon Labuschagne

Merge request reports