Skip to content

Resolve Migrate '.fa-spinner' to '.spinner' for 'app/views/projects/blob/viewers'

What does this MR do?

This MR migrates '.fa-spinner' to '.spinner' for 'app/views/projects/blob/viewers'in this issue #202589 (closed)

Screenshots

app/views/projects/blob/viewers/_loading.html.haml

Before After
blob2 screencast-127.0.0.1_3000-2020.04__8_

app/views/projects/blob/viewers/_loading_auxiliary.html.haml

Before After
screencast-127.0.0.1_3000-2020.04__11_ screencast-127.0.0.1_3000-2020.04__7_

app/views/projects/blob/viewers/_gitlab_ci_yml_loading.html.haml

Before After
Screen_Recording_2020-04-09_at_12.45.05 Screen_Recording_2020-04-09_at_12.44.29

app/views/projects/blob/viewers/_sketch.html.haml

Before After
screencast-localhost_3000-2020.04__10_ screencast-127.0.0.1_3000-2020.04__1_

app/views/projects/blob/viewers/_stl.html.haml

Before After
screencast-localhost_3000-2020.04__11_ screencast-127.0.0.1_3000-2020.04__15_

app/views/projects/blob/viewers/_route_map_loading.html.haml

Before After
Screen_Recording_2020-04-14_at_12.14.18 Screen_Recording_2020-04-14_at_12.13.53

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports