Migrate '.fa-spinner' to '.spinner' for admin/application_settings
requested to merge 202592-migrate-fa-spinner-to-spinner-for-app-views-admin-application_settings into master
What does this MR do?
- Move
.fa-spinner
to use new.spinner
class - While I was working on this, I found a bug with the vertical alignment of the spinner when placed inside a button, similar to what I reported in #199708 (closed)
Before | After |
---|---|
![]() |
![]() |
Screenshots
Animation
Screen_Recording_2020-02-11_at_22.55.31
Vertical alignment of spinner inside button
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #202592 (closed)
Edited by Justin Ho Tuan Duong