Skip to content

Migrate '.fa-spinner' to '.spinner' for admin/application_settings

What does this MR do?

  • Move .fa-spinner to use new .spinner class
  • While I was working on this, I found a bug with the vertical alignment of the spinner when placed inside a button, similar to what I reported in #199708 (closed)
Before After
Screen_Shot_2020-02-11_at_22.38.56 Screen_Shot_2020-02-11_at_22.54.07

Screenshots

Animation

Screen_Recording_2020-02-11_at_22.55.31

Vertical alignment of spinner inside button

Screen_Shot_2020-02-11_at_22.54.46

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #202592 (closed)

Edited by Justin Ho Tuan Duong

Merge request reports