Skip to content

Drop etag cache on logs API

Adrien Kohlbecker requested to merge ak/drop-etag into master

What does this MR do?

Based on #202522 (comment 284246887)

The Etag cache introduced in 5c7a4307 does not work today because we use query parameters. Since the number of parameters we use will only grow, it doesn't make sense to move to path parameters.

It has also been a source of bugs in recent history, eg #197229 (closed). Most notably also, the logs explorer currently does not work in Firefox, which etag caching behavior differs from Chrome's.

This also has the advantage of uncoupling the logs service from the specific URL used to make the request, which will help us in opening access through other APIs (#31105 (closed)).

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports