Add background operation to clear stale MR cached HTML

zlirequested to merge
zl/607937 into master

What does this MR do and why?

Adds Gitlab::BackgroundOperation::MergeRequestsClearStaleCachedHtml, a recurring cell-local background operation that clears the rendered-Markdown cache (title_html, description_html, cached_markdown_version) on merge requests whose cached_markdown_version is below the version currently treated as current.

This is the "clear stale cache version MRs" job from the plan agreed in #607937 (part of epic &20233). A row on a stale cached_markdown_version is already treated the same as a NULL-cached row: the next read re-renders both HTML fields and rewrites the latest version. Clearing such rows up front therefore reclaims wasted *_html bytes on merge_requests with no extra rendering load — those rows would re-render and rewrite on access anyway.

Nothing user-facing changes.

Target version logic

The version below which rows are considered stale follows the markdown cache rollout state:

  • During a phased CACHE_COMMONMARK_VERSION rollout, target is previous_cached_markdown_version, so only true stragglers (rows below the previous version) are swept; the previous/current populations, still rolling, are left alone.
  • In steady state (no rollout), it falls back to cached_markdown_version_for_write, sweeping everything below the current version.

Because writes always use the current version, cleared rows re-render and come back at the current version, so they do not re-qualify until the next bump.

Design decisions

  • No scope_to; filter inside each_sub_batch. scope_to pushes the predicate into batch-boundary calculation, which per the docs must be backed by an index. merge_requests.cached_markdown_version is not indexed, and adding a multi-GB index to a large table we are trying to shrink (and the predicate matches ~50% of rows, so it is not selective) would be counterproductive. Filtering in the sub-batch lets batches walk the full primary-key range and filter in place — the framework's prescribed pattern for an unindexed filter.
  • Weekly cadence (CronEnqueueWorker, Sundays 03:30 UTC). The workload is two large sweeps tied to a bump cycle (the pre-previous stragglers now, then the parked previous-version rows when the rollout completes), then near-idle until the next bump. Weekly avoids burning a full PK scan daily to clear almost nothing in steady state. CronEnqueueWorker enqueue is idempotent.

Database

Click to expand 
[2] pry(main)> ApplicationRecord.logger = Logger.new($stdout)
klass = Gitlab::BackgroundOperation::MergeRequestsClearStaleCachedHtml
=> Gitlab::BackgroundOperation::MergeRequestsClearStaleCachedHtml
[3] pry(main)> min_id = MergeRequest.minimum(:id)
  MergeRequest Minimum (323.8ms)  SELECT MIN("merge_requests"."id") FROM "merge_requests" /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:(pry):4:in `__pry__'*/
=> 1
[4] pry(main)> max_id = MergeRequest.where('id >= ?', min_id).order(:id).offset(999).limit(1).pick(:id)
  MergeRequest Pluck (306.5ms)  SELECT "merge_requests"."id" FROM "merge_requests" WHERE (id >= 1) ORDER BY "merge_requests"."id" ASC LIMIT 1 OFFSET 999 /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:(pry):5:in `__pry__'*/
=> 1505
[5] pry(main)> job = klass.new(
  batch_table: :merge_requests, batch_column: :id,
  sub_batch_size: 100, pause_ms: 100,
  connection: ApplicationRecord.connection,
[5] pry(main)> job = klass.new(sor: [max_id]
  batch_table: :merge_requests, batch_column: :id,
  sub_batch_size: 100, pause_ms: 100,
  connection: ApplicationRecord.connection,
  min_cursor: [min_id], max_cursor: [max_id]
=> #<Gitlab::BackgroundOperation::MergeRequestsClearStaleCachedHtml:0x00000001447ce300
 @batch_column=:id,
 @batch_table=:merge_requests,
 @connection=
  #<Gitlab::Database::LoadBalancing::ConnectionProxy:0x00000001345b6960
   @load_balancer=
    #<Gitlab::Database::LoadBalancing::LoadBalancer:0x00000001345b70e0
     @configuration=
      #<Gitlab::Database::LoadBalancing::Configuration:0x0000000133475160
       @hosts=[],
       @max_replication_difference=8388608,
       @max_replication_lag_time=60.0,
       @model=ActiveRecord::Base,
       @replica_check_interval=60.0,
       @service_discovery=
        {:nameserver=>"localhost",
         :port=>8600,
         :record=>nil,
         :record_type=>"A",
         :interval=>60,
         :disconnect_timeout=>120,
         :use_tcp=>false,
         :max_replica_pools=>nil}>,
     @host_list=
      #<Gitlab::Database::LoadBalancing::HostList:0x00000001345b6ff0
       @hosts=
        [#<Gitlab::Database::LoadBalancing::PrimaryHost:0x00000001345b7040
          @load_balancer=#<Gitlab::Database::LoadBalancing::LoadBalancer:0x00000001345b70e0 ...>>],
       @index=0,
       @mutex=#<Thread::Mutex:0x0000000132bfb048>>,
     @primary_only=true>>,
 @job_arguments=[],
 @max_cursor=[1505],
 @min_cursor=[1],
 @pause_ms=100,
 @sub_batch_exception=nil,
 @sub_batch_size=100>
[6] pry(main)> job.perform
   Load (305.9ms)  SELECT "merge_requests".* FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id") >= (1) ORDER BY "merge_requests"."id" ASC LIMIT 2 OFFSET 99 /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
  ApplicationSetting Load (2048.6ms)  SELECT "application_settings"."id", "application_settings"."default_projects_limit", "application_settings"."signup_enabled", "application_settings"."gravatar_enabled", "application_settings"."created_at", "application_settings"."updated_at", "application_settings"."home_page_url", "application_settings"."default_branch_protection", "application_settings"."restricted_visibility_levels", "application_settings"."max_attachment_size", "application_settings"."version_check_enabled", "application_settings"."default_project_visibility", "application_settings"."default_snippet_visibility", "application_settings"."user_oauth_applications", "application_settings"."after_sign_out_path", "application_settings"."session_expire_delay", "application_settings"."import_sources", "application_settings"."help_page_text", "application_settings"."shared_runners_enabled", "application_settings"."max_artifacts_size", "application_settings"."max_pages_size", "application_settings"."recaptcha_enabled", "application_settings"."require_two_factor_authentication", "application_settings"."two_factor_grace_period", "application_settings"."metrics_enabled", "application_settings"."metrics_host", "application_settings"."metrics_pool_size", "application_settings"."metrics_timeout", "application_settings"."metrics_method_call_threshold", "application_settings"."metrics_port", "application_settings"."metrics_sample_interval", "application_settings"."akismet_enabled", "application_settings"."email_author_in_body", "application_settings"."default_group_visibility", "application_settings"."repository_checks_enabled", "application_settings"."shared_runners_text", "application_settings"."metrics_packet_size", "application_settings"."disabled_oauth_sign_in_sources", "application_settings"."health_check_access_token", "application_settings"."container_registry_token_expire_delay", "application_settings"."after_sign_up_text", "application_settings"."user_default_external", "application_settings"."repository_storages", "application_settings"."enabled_git_access_protocol", "application_settings"."usage_ping_enabled", "application_settings"."help_page_text_html", "application_settings"."shared_runners_text_html", "application_settings"."after_sign_up_text_html", "application_settings"."housekeeping_enabled", "application_settings"."housekeeping_bitmaps_enabled", "application_settings"."housekeeping_incremental_repack_period", "application_settings"."housekeeping_full_repack_period", "application_settings"."housekeeping_gc_period", "application_settings"."html_emails_enabled", "application_settings"."plantuml_url", "application_settings"."plantuml_enabled", "application_settings"."shared_runners_minutes", "application_settings"."repository_size_limit", "application_settings"."terminal_max_session_time", "application_settings"."unique_ips_limit_per_user", "application_settings"."unique_ips_limit_time_window", "application_settings"."unique_ips_limit_enabled", "application_settings"."default_artifacts_expire_in", "application_settings"."elasticsearch_url", "application_settings"."geo_status_timeout", "application_settings"."uuid", "application_settings"."polling_interval_multiplier", "application_settings"."cached_markdown_version", "application_settings"."check_namespace_plan", "application_settings"."mirror_max_delay", "application_settings"."mirror_max_capacity", "application_settings"."mirror_capacity_threshold", "application_settings"."prometheus_metrics_enabled", "application_settings"."authorized_keys_enabled", "application_settings"."help_page_hide_commercial_content", "application_settings"."help_page_support_url", "application_settings"."slack_app_enabled", "application_settings"."slack_app_id", "application_settings"."performance_bar_allowed_group_id", "application_settings"."allow_group_owners_to_manage_ldap", "application_settings"."rsa_key_restriction", "application_settings"."dsa_key_restriction", "application_settings"."ecdsa_key_restriction", "application_settings"."ed25519_key_restriction", "application_settings"."hashed_storage_enabled", "application_settings"."project_export_enabled", "application_settings"."auto_devops_enabled", "application_settings"."throttle_unauthenticated_enabled", "application_settings"."throttle_unauthenticated_requests_per_period", "application_settings"."throttle_unauthenticated_period_in_seconds", "application_settings"."throttle_authenticated_api_enabled", "application_settings"."throttle_authenticated_api_requests_per_period", "application_settings"."throttle_authenticated_api_period_in_seconds", "application_settings"."throttle_authenticated_web_enabled", "application_settings"."throttle_authenticated_web_requests_per_period", "application_settings"."throttle_authenticated_web_period_in_seconds", "application_settings"."gitaly_timeout_default", "application_settings"."gitaly_timeout_medium", "application_settings"."gitaly_timeout_fast", "application_settings"."password_authentication_enabled_for_web", "application_settings"."password_authentication_enabled_for_git", "application_settings"."mirror_available", "application_settings"."default_project_creation", "application_settings"."auto_devops_domain", "application_settings"."pages_domain_verification_enabled", "application_settings"."external_authorization_service_enabled", "application_settings"."external_authorization_service_url", "application_settings"."external_authorization_service_default_label", "application_settings"."external_authorization_service_timeout", "application_settings"."external_auth_client_cert", "application_settings"."encrypted_external_auth_client_key", "application_settings"."encrypted_external_auth_client_key_iv", "application_settings"."encrypted_external_auth_client_key_pass", "application_settings"."encrypted_external_auth_client_key_pass_iv", "application_settings"."email_additional_text", "application_settings"."enforce_terms", "application_settings"."pseudonymizer_enabled", "application_settings"."hide_third_party_offers", "application_settings"."custom_project_templates_group_id", "application_settings"."snowplow_enabled", "application_settings"."snowplow_cookie_domain", "application_settings"."user_default_internal_regex", "application_settings"."file_template_project_id", "application_settings"."user_show_add_ssh_key_message", "application_settings"."receive_max_input_size", "application_settings"."usage_stats_set_by_user_id", "application_settings"."diff_max_patch_bytes", "application_settings"."archive_builds_in_seconds", "application_settings"."commit_email_hostname", "application_settings"."runners_registration_token_encrypted", "application_settings"."protected_ci_variables", "application_settings"."first_day_of_week", "application_settings"."local_markdown_version", "application_settings"."geo_node_allowed_ips", "application_settings"."lets_encrypt_notification_email", "application_settings"."lets_encrypt_terms_of_service_accepted", "application_settings"."dns_rebinding_protection_enabled", "application_settings"."encrypted_lets_encrypt_private_key", "application_settings"."encrypted_lets_encrypt_private_key_iv", "application_settings"."lock_memberships_to_ldap", "application_settings"."default_project_deletion_protection", "application_settings"."time_tracking_limit_to_hours", "application_settings"."grafana_enabled", "application_settings"."grafana_url", "application_settings"."outbound_local_requests_whitelist", "application_settings"."raw_blob_request_limit", "application_settings"."allow_local_requests_from_web_hooks_and_services", "application_settings"."allow_local_requests_from_system_hooks", "application_settings"."snowplow_collector_hostname", "application_settings"."asset_proxy_enabled", "application_settings"."asset_proxy_url", "application_settings"."encrypted_asset_proxy_secret_key", "application_settings"."encrypted_asset_proxy_secret_key_iv", "application_settings"."login_recaptcha_protection_enabled", "application_settings"."static_objects_external_storage_url", "application_settings"."throttle_protected_paths_enabled", "application_settings"."throttle_protected_paths_requests_per_period", "application_settings"."throttle_protected_paths_period_in_seconds", "application_settings"."protected_paths", "application_settings"."throttle_incident_management_notification_enabled", "application_settings"."throttle_incident_management_notification_period_in_seconds", "application_settings"."throttle_incident_management_notification_per_period", "application_settings"."push_event_hooks_limit", "application_settings"."push_event_activities_limit", "application_settings"."custom_http_clone_url_root", "application_settings"."deletion_adjourned_period", "application_settings"."productivity_analytics_start_date", "application_settings"."snowplow_app_id", "application_settings"."eks_integration_enabled", "application_settings"."eks_account_id", "application_settings"."eks_access_key_id", "application_settings"."encrypted_eks_secret_access_key_iv", "application_settings"."encrypted_eks_secret_access_key", "application_settings"."sourcegraph_enabled", "application_settings"."sourcegraph_url", "application_settings"."license_trial_ends_on", "application_settings"."sourcegraph_public_only", "application_settings"."default_ci_config_path", "application_settings"."encrypted_akismet_api_key", "application_settings"."encrypted_akismet_api_key_iv", "application_settings"."encrypted_elasticsearch_aws_secret_access_key", "application_settings"."encrypted_elasticsearch_aws_secret_access_key_iv", "application_settings"."encrypted_recaptcha_private_key", "application_settings"."encrypted_recaptcha_private_key_iv", "application_settings"."encrypted_recaptcha_site_key", "application_settings"."encrypted_recaptcha_site_key_iv", "application_settings"."encrypted_slack_app_secret", "application_settings"."encrypted_slack_app_secret_iv", "application_settings"."encrypted_slack_app_verification_token", "application_settings"."encrypted_slack_app_verification_token_iv", "application_settings"."max_personal_access_token_lifetime", "application_settings"."snippet_size_limit", "application_settings"."minimum_password_length", "application_settings"."updating_name_disabled_for_users", "application_settings"."force_pages_access_control", "application_settings"."disable_overriding_approvers_per_merge_request", "application_settings"."prevent_merge_requests_author_approval", "application_settings"."prevent_merge_requests_committers_approval", "application_settings"."email_restrictions_enabled", "application_settings"."email_restrictions", "application_settings"."container_expiration_policies_enable_historic_entries", "application_settings"."issues_create_limit", "application_settings"."push_rule_id", "application_settings"."group_owners_can_manage_default_branch_protection", "application_settings"."container_registry_vendor", "application_settings"."container_registry_version", "application_settings"."container_registry_features", "application_settings"."spam_check_endpoint_url", "application_settings"."spam_check_endpoint_enabled", "application_settings"."repository_storages_weighted", "application_settings"."max_import_size", "application_settings"."compliance_frameworks", "application_settings"."notify_on_unknown_sign_in", "application_settings"."default_branch_name", "application_settings"."project_import_limit", "application_settings"."project_export_limit", "application_settings"."project_download_export_limit", "application_settings"."group_import_limit", "application_settings"."group_export_limit", "application_settings"."group_download_export_limit", "application_settings"."maintenance_mode", "application_settings"."maintenance_mode_message", "application_settings"."wiki_page_max_content_bytes", "application_settings"."enforce_namespace_storage_limit", "application_settings"."container_registry_delete_tags_service_timeout", "application_settings"."gitpod_enabled", "application_settings"."gitpod_url", "application_settings"."abuse_notification_email", "application_settings"."require_admin_approval_after_user_signup", "application_settings"."help_page_documentation_base_url", "application_settings"."automatic_purchased_storage_allocation", "application_settings"."encrypted_ci_jwt_signing_key", "application_settings"."encrypted_ci_jwt_signing_key_iv", "application_settings"."container_registry_expiration_policies_worker_capacity", "application_settings"."secret_detection_token_revocation_enabled", "application_settings"."secret_detection_token_revocation_url", "application_settings"."encrypted_secret_detection_token_revocation_token", "application_settings"."encrypted_secret_detection_token_revocation_token_iv", "application_settings"."new_user_signups_cap", "application_settings"."domain_denylist_enabled", "application_settings"."domain_denylist", "application_settings"."domain_allowlist", "application_settings"."encrypted_cloud_license_auth_token", "application_settings"."encrypted_cloud_license_auth_token_iv", "application_settings"."secret_detection_revocation_token_types_url", "application_settings"."kroki_url", "application_settings"."kroki_enabled", "application_settings"."disable_feed_token", "application_settings"."personal_access_token_prefix", "application_settings"."rate_limiting_response_text", "application_settings"."container_registry_cleanup_tags_service_max_list_size", "application_settings"."invisible_captcha_enabled", "application_settings"."git_two_factor_session_expiry", "application_settings"."keep_latest_artifact", "application_settings"."notes_create_limit", "application_settings"."notes_create_limit_allowlist", "application_settings"."kroki_formats", "application_settings"."asset_proxy_whitelist", "application_settings"."admin_mode", "application_settings"."external_pipeline_validation_service_timeout", "application_settings"."encrypted_external_pipeline_validation_service_token", "application_settings"."encrypted_external_pipeline_validation_service_token_iv", "application_settings"."external_pipeline_validation_service_url", "application_settings"."throttle_unauthenticated_packages_api_requests_per_period", "application_settings"."throttle_unauthenticated_packages_api_period_in_seconds", "application_settings"."throttle_authenticated_packages_api_requests_per_period", "application_settings"."throttle_authenticated_packages_api_period_in_seconds", "application_settings"."throttle_unauthenticated_packages_api_enabled", "application_settings"."throttle_authenticated_packages_api_enabled", "application_settings"."deactivate_dormant_users", "application_settings"."whats_new_variant", "application_settings"."encrypted_spam_check_api_key", "application_settings"."encrypted_spam_check_api_key_iv", "application_settings"."floc_enabled", "application_settings"."encrypted_elasticsearch_password", "application_settings"."encrypted_elasticsearch_password_iv", "application_settings"."diff_max_lines", "application_settings"."diff_max_files", "application_settings"."valid_runner_registrars", "application_settings"."encrypted_mailgun_signing_key", "application_settings"."encrypted_mailgun_signing_key_iv", "application_settings"."mailgun_events_enabled", "application_settings"."usage_ping_features_enabled", "application_settings"."encrypted_customers_dot_jwt_signing_key", "application_settings"."encrypted_customers_dot_jwt_signing_key_iv", "application_settings"."throttle_unauthenticated_files_api_requests_per_period", "application_settings"."throttle_unauthenticated_files_api_period_in_seconds", "application_settings"."throttle_authenticated_files_api_requests_per_period", "application_settings"."throttle_authenticated_files_api_period_in_seconds", "application_settings"."throttle_unauthenticated_files_api_enabled", "application_settings"."throttle_authenticated_files_api_enabled", "application_settings"."max_yaml_size_bytes", "application_settings"."max_yaml_depth", "application_settings"."throttle_authenticated_git_lfs_requests_per_period", "application_settings"."throttle_authenticated_git_lfs_period_in_seconds", "application_settings"."throttle_authenticated_git_lfs_enabled", "application_settings"."user_deactivation_emails_enabled", "application_settings"."throttle_unauthenticated_api_enabled", "application_settings"."throttle_unauthenticated_api_requests_per_period", "application_settings"."throttle_unauthenticated_api_period_in_seconds", "application_settings"."sidekiq_job_limiter_mode", "application_settings"."sidekiq_job_limiter_compression_threshold_bytes", "application_settings"."sidekiq_job_limiter_limit_bytes", "application_settings"."jobs_per_stage_page_size", "application_settings"."throttle_unauthenticated_deprecated_api_requests_per_period", "application_settings"."throttle_unauthenticated_deprecated_api_period_in_seconds", "application_settings"."throttle_unauthenticated_deprecated_api_enabled", "application_settings"."throttle_authenticated_deprecated_api_requests_per_period", "application_settings"."throttle_authenticated_deprecated_api_period_in_seconds", "application_settings"."throttle_authenticated_deprecated_api_enabled", "application_settings"."dependency_proxy_ttl_group_policy_worker_capacity", "application_settings"."content_validation_endpoint_url", "application_settings"."encrypted_content_validation_api_key", "application_settings"."encrypted_content_validation_api_key_iv", "application_settings"."content_validation_endpoint_enabled", "application_settings"."sentry_enabled", "application_settings"."sentry_dsn", "application_settings"."sentry_clientside_dsn", "application_settings"."sentry_environment", "application_settings"."static_objects_external_storage_auth_token_encrypted", "application_settings"."max_ssh_key_lifetime", "application_settings"."future_subscriptions", "application_settings"."runner_token_expiration_interval", "application_settings"."group_runner_token_expiration_interval", "application_settings"."project_runner_token_expiration_interval", "application_settings"."ecdsa_sk_key_restriction", "application_settings"."ed25519_sk_key_restriction", "application_settings"."users_get_by_id_limit", "application_settings"."users_get_by_id_limit_allowlist", "application_settings"."container_registry_expiration_policies_caching", "application_settings"."search_rate_limit", "application_settings"."search_rate_limit_unauthenticated", "application_settings"."encrypted_database_grafana_api_key", "application_settings"."encrypted_database_grafana_api_key_iv", "application_settings"."database_grafana_api_url", "application_settings"."database_grafana_tag", "application_settings"."public_runner_releases_url", "application_settings"."delete_inactive_projects", "application_settings"."inactive_projects_delete_after_months", "application_settings"."inactive_projects_min_size_mb", "application_settings"."inactive_projects_send_warning_email_after_months", "application_settings"."encrypted_arkose_labs_public_api_key", "application_settings"."encrypted_arkose_labs_public_api_key_iv", "application_settings"."encrypted_arkose_labs_private_api_key", "application_settings"."encrypted_arkose_labs_private_api_key_iv", "application_settings"."arkose_labs_namespace", "application_settings"."max_export_size", "application_settings"."pipeline_limit_per_project_user_sha", "application_settings"."encrypted_slack_app_signing_secret", "application_settings"."encrypted_slack_app_signing_secret_iv", "application_settings"."globally_allowed_ips", "application_settings"."dingtalk_integration_enabled", "application_settings"."encrypted_dingtalk_corpid", "application_settings"."encrypted_dingtalk_corpid_iv", "application_settings"."encrypted_dingtalk_app_key", "application_settings"."encrypted_dingtalk_app_key_iv", "application_settings"."encrypted_dingtalk_app_secret", "application_settings"."encrypted_dingtalk_app_secret_iv", "application_settings"."password_uppercase_required", "application_settings"."password_lowercase_required", "application_settings"."password_number_required", "application_settings"."password_symbol_required", "application_settings"."jira_connect_application_key", "application_settings"."license_usage_data_exported", "application_settings"."phone_verification_code_enabled", "application_settings"."max_number_of_repository_downloads", "application_settings"."max_number_of_repository_downloads_within_time_period", "application_settings"."feishu_integration_enabled", "application_settings"."encrypted_feishu_app_key", "application_settings"."encrypted_feishu_app_key_iv", "application_settings"."encrypted_feishu_app_secret", "application_settings"."encrypted_feishu_app_secret_iv", "application_settings"."git_rate_limit_users_allowlist", "application_settings"."error_tracking_enabled", "application_settings"."error_tracking_api_url", "application_settings"."error_tracking_access_token_encrypted", "application_settings"."deactivate_dormant_users_period", "application_settings"."auto_ban_user_on_excessive_projects_download", "application_settings"."invitation_flow_enforcement", "application_settings"."max_pages_custom_domains_per_project", "application_settings"."cube_api_base_url", "application_settings"."encrypted_cube_api_key", "application_settings"."encrypted_cube_api_key_iv", "application_settings"."dashboard_limit_enabled", "application_settings"."dashboard_limit", "application_settings"."can_create_group", "application_settings"."password_expiration_enabled", "application_settings"."password_expires_in_days", "application_settings"."password_expires_notice_before_days", "application_settings"."product_analytics_enabled", "application_settings"."jira_connect_proxy_url", "application_settings"."email_confirmation_setting", "application_settings"."disable_admin_oauth_scopes", "application_settings"."default_preferred_language", "application_settings"."disable_download_button", "application_settings"."encrypted_telesign_customer_xid", "application_settings"."encrypted_telesign_customer_xid_iv", "application_settings"."encrypted_telesign_api_key", "application_settings"."encrypted_telesign_api_key_iv", "application_settings"."max_terraform_state_size_bytes", "application_settings"."disable_personal_access_tokens", "application_settings"."bulk_import_enabled", "application_settings"."allow_runner_registration_token", "application_settings"."user_defaults_to_private_profile", "application_settings"."allow_possible_spam", "application_settings"."search_max_shard_size_gb", "application_settings"."search_max_docs_denominator", "application_settings"."search_min_docs_before_rollover", "application_settings"."deactivation_email_additional_text", "application_settings"."git_rate_limit_users_alertlist", "application_settings"."jira_connect_public_key_storage_enabled", "application_settings"."security_policy_global_group_approvers_enabled", "application_settings"."allow_deploy_tokens_and_keys_with_external_authn", "application_settings"."default_syntax_highlighting_theme", "application_settings"."projects_api_rate_limit_unauthenticated", "application_settings"."deny_all_requests_except_allowed", "application_settings"."product_analytics_data_collector_host", "application_settings"."lock_memberships_to_saml", "application_settings"."gitlab_dedicated_instance", "application_settings"."update_runner_versions_enabled", "application_settings"."database_max_running_batched_background_migrations", "application_settings"."silent_mode_enabled", "application_settings"."package_metadata_purl_types", "application_settings"."encrypted_product_analytics_configurator_connection_string", "application_settings"."encrypted_product_analytics_configurator_connection_string_iv", "application_settings"."ci_max_includes", "application_settings"."remember_me_enabled", "application_settings"."allow_account_deletion", "application_settings"."wiki_asciidoc_allow_uri_includes", "application_settings"."namespace_aggregation_schedule_lease_duration_in_seconds", "application_settings"."diagramsnet_enabled", "application_settings"."diagramsnet_url", "application_settings"."vertex_ai_host", "application_settings"."vertex_ai_project", "application_settings"."delete_unconfirmed_users", "application_settings"."unconfirmed_users_delete_after_days", "application_settings"."default_branch_protection_defaults", "application_settings"."gitlab_shell_operation_limit", "application_settings"."namespace_storage_forks_cost_factor", "application_settings"."bulk_import_max_download_file_size", "application_settings"."max_import_remote_file_size", "application_settings"."protected_paths_for_get_request", "application_settings"."max_decompressed_archive_size", "application_settings"."prometheus_alert_db_indicators_settings", "application_settings"."sentry_clientside_traces_sample_rate", "application_settings"."ci_max_total_yaml_size_bytes", "application_settings"."decompress_archive_file_timeout", "application_settings"."search_rate_limit_allowlist", "application_settings"."snowplow_database_collector_hostname", "application_settings"."container_registry_db_enabled", "application_settings"."project_jobs_api_rate_limit", "application_settings"."max_login_attempts", "application_settings"."failed_login_attempts_unlock_period_in_minutes", "application_settings"."math_rendering_limits_enabled", "application_settings"."service_access_tokens_expiration_enforced", "application_settings"."enable_artifact_external_redirect_warning_page", "application_settings"."allow_project_creation_for_guest_and_below", "application_settings"."update_namespace_name_rate_limit", "application_settings"."can_create_organization", "application_settings"."make_profile_private", "application_settings"."web_ide_oauth_application_id", "application_settings"."instance_level_ai_beta_features_enabled", "application_settings"."security_txt_content", "application_settings"."bulk_import_concurrent_pipeline_batch_limit", "application_settings"."encrypted_arkose_labs_data_exchange_key", "application_settings"."encrypted_arkose_labs_data_exchange_key_iv", "application_settings"."require_admin_two_factor_authentication", "application_settings"."rate_limits", "application_settings"."enable_member_promotion_management", "application_settings"."lock_math_rendering_limits_enabled", "application_settings"."security_approval_policies_limit", "application_settings"."encrypted_arkose_labs_client_xid", "application_settings"."encrypted_arkose_labs_client_xid_iv", "application_settings"."encrypted_arkose_labs_client_secret", "application_settings"."encrypted_arkose_labs_client_secret_iv", "application_settings"."duo_features_enabled", "application_settings"."lock_duo_features_enabled", "application_settings"."asciidoc_max_includes", "application_settings"."clickhouse", "application_settings"."include_optional_metrics_in_service_ping", "application_settings"."zoekt_settings", "application_settings"."service_ping_settings", "application_settings"."rate_limits_unauthenticated_git_http", "application_settings"."package_registry", "application_settings"."importers", "application_settings"."code_creation", "application_settings"."code_suggestions_api_rate_limit", "application_settings"."ai_action_api_rate_limit", "application_settings"."require_personal_access_token_expiry", "application_settings"."duo_workflow", "application_settings"."max_artifacts_content_include_size", "application_settings"."max_number_of_vulnerabilities_per_project", "application_settings"."cluster_agents", "application_settings"."observability_backend_ssl_verification_enabled", "application_settings"."pages", "application_settings"."security_policies", "application_settings"."spp_repository_pipeline_access", "application_settings"."lock_spp_repository_pipeline_access", "application_settings"."required_instance_ci_template", "application_settings"."enforce_ci_inbound_job_token_scope_enabled", "application_settings"."allow_top_level_group_owners_to_create_service_accounts", "application_settings"."sign_in_restrictions", "application_settings"."transactional_emails", "application_settings"."identity_verification_settings", "application_settings"."integrations", "application_settings"."user_seat_management", "application_settings"."resource_usage_limits", "application_settings"."show_migrate_from_jenkins_banner", "application_settings"."secret_detection_service_url", "application_settings"."encrypted_secret_detection_service_auth_token", "application_settings"."encrypted_secret_detection_service_auth_token_iv", "application_settings"."encrypted_ci_job_token_signing_key", "application_settings"."encrypted_ci_job_token_signing_key_iv", "application_settings"."elasticsearch", "application_settings"."oauth_provider", "application_settings"."observability_settings", "application_settings"."search", "application_settings"."anti_abuse_settings", "application_settings"."secret_push_protection_available", "application_settings"."vscode_extension_marketplace", "application_settings"."token_prefixes", "application_settings"."ci_cd_settings", "application_settings"."database_reindexing", "application_settings"."duo_chat", "application_settings"."group_settings", "application_settings"."response_limits", "application_settings"."web_based_commit_signing_enabled", "application_settings"."lock_web_based_commit_signing_enabled", "application_settings"."tmp_asset_proxy_secret_key", "application_settings"."editor_extensions", "application_settings"."security_and_compliance_settings", "application_settings"."default_profile_preferences", "application_settings"."sdrs_url", "application_settings"."sdrs_enabled", "application_settings"."sdrs_jwt_signing_key", "application_settings"."resource_access_tokens_settings", "application_settings"."auto_duo_code_review_enabled", "application_settings"."lock_auto_duo_code_review_enabled", "application_settings"."workspaces_oauth_application_id", "application_settings"."usage_ping_generation_enabled", "application_settings"."duo_remote_flows_enabled", "application_settings"."lock_duo_remote_flows_enabled", "application_settings"."terraform_state_settings", "application_settings"."duo_foundational_flows_enabled", "application_settings"."lock_duo_foundational_flows_enabled", "application_settings"."iframe_rendering_enabled", "application_settings"."iframe_rendering_allowlist", "application_settings"."database_settings", "application_settings"."usage_billing", "application_settings"."topology_service_settings", "application_settings"."secrets_manager_settings", "application_settings"."duo_workflows_default_image_registry", "application_settings"."diagram_proxy", "application_settings"."built_in_project_templates_enabled", "application_settings"."lock_built_in_project_templates_enabled", "application_settings"."tool_approval_for_session_enabled", "application_settings"."lock_tool_approval_for_session_enabled", "application_settings"."personal_access_token_settings", "application_settings"."diff_limits", "application_settings"."markdown_settings", "application_settings"."active_context_settings", "application_settings"."duo_settings", "application_settings"."mcp_server_settings", "application_settings"."secrets_manager_instance_enrolled", "application_settings"."duo_template_project_id", "application_settings"."default_security_tracked_context_quota", "application_settings"."oauth_settings", "application_settings"."logging_settings", "application_settings"."dependency_management_settings", "application_settings"."require_sha_for_merge", "application_settings"."lock_require_sha_for_merge", "application_settings"."ai_audit_events_storage_enabled", "application_settings"."lock_ai_audit_events_storage_enabled", "application_settings"."ai_gateway_url", "application_settings"."ai_gateway_timeout_seconds", "application_settings"."enabled_instance_verbose_ai_logs", "application_settings"."duo_agent_platform_service_url", "application_settings"."self_hosted_duo_agent_platform_service_secure", "application_settings"."sidekiq_timezone_override", "application_settings"."nats_settings", "application_settings"."o11y_oauth_application_id" FROM "application_settings" ORDER BY "application_settings"."id" DESC LIMIT 1 /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/app/models/concerns/cacheable_attributes.rb:19:in `current_without_cache'*/
  #<Class:0x000000014ff59740> Update All (673.9ms)  UPDATE "merge_requests" SET "title_html" = NULL, "description_html" = NULL, "cached_markdown_version" = NULL, "lock_version" = COALESCE("lock_version", 0) + 1 WHERE ("merge_requests"."id") IN (SELECT "merge_requests"."id" FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id") >= (1) AND (cached_markdown_version < 2162697 OR ( cached_markdown_version IS NOT NULL AND title_html IS NULL AND description_html IS NULL ) OR ( cached_markdown_version IS NULL AND (title_html IS NOT NULL OR description_html IS NOT NULL) )) ORDER BY "merge_requests"."id" ASC LIMIT 100) /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
   Load (367.9ms)  SELECT "merge_requests".* FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 138) ORDER BY "merge_requests"."id" ASC LIMIT 2 OFFSET 99 /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
  #<Class:0x000000014ff59740> Update All (325.3ms)  UPDATE "merge_requests" SET "title_html" = NULL, "description_html" = NULL, "cached_markdown_version" = NULL, "lock_version" = COALESCE("lock_version", 0) + 1 WHERE ("merge_requests"."id") IN (SELECT "merge_requests"."id" FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 138) AND (cached_markdown_version < 2162697 OR ( cached_markdown_version IS NOT NULL AND title_html IS NULL AND description_html IS NULL ) OR ( cached_markdown_version IS NULL AND (title_html IS NOT NULL OR description_html IS NOT NULL) )) ORDER BY "merge_requests"."id" ASC LIMIT 100) /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
   Load (305.7ms)  SELECT "merge_requests".* FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 268) ORDER BY "merge_requests"."id" ASC LIMIT 2 OFFSET 99 /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
  #<Class:0x000000014ff59740> Update All (300.9ms)  UPDATE "merge_requests" SET "title_html" = NULL, "description_html" = NULL, "cached_markdown_version" = NULL, "lock_version" = COALESCE("lock_version", 0) + 1 WHERE ("merge_requests"."id") IN (SELECT "merge_requests"."id" FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 268) AND (cached_markdown_version < 2162697 OR ( cached_markdown_version IS NOT NULL AND title_html IS NULL AND description_html IS NULL ) OR ( cached_markdown_version IS NULL AND (title_html IS NOT NULL OR description_html IS NOT NULL) )) ORDER BY "merge_requests"."id" ASC LIMIT 100) /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
   Load (308.8ms)  SELECT "merge_requests".* FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 395) ORDER BY "merge_requests"."id" ASC LIMIT 2 OFFSET 99 /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
  #<Class:0x000000014ff59740> Update All (309.8ms)  UPDATE "merge_requests" SET "title_html" = NULL, "description_html" = NULL, "cached_markdown_version" = NULL, "lock_version" = COALESCE("lock_version", 0) + 1 WHERE ("merge_requests"."id") IN (SELECT "merge_requests"."id" FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 395) AND (cached_markdown_version < 2162697 OR ( cached_markdown_version IS NOT NULL AND title_html IS NULL AND description_html IS NULL ) OR ( cached_markdown_version IS NULL AND (title_html IS NOT NULL OR description_html IS NOT NULL) )) ORDER BY "merge_requests"."id" ASC LIMIT 100) /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
   Load (344.0ms)  SELECT "merge_requests".* FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 511) ORDER BY "merge_requests"."id" ASC LIMIT 2 OFFSET 99 /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
  #<Class:0x000000014ff59740> Update All (309.4ms)  UPDATE "merge_requests" SET "title_html" = NULL, "description_html" = NULL, "cached_markdown_version" = NULL, "lock_version" = COALESCE("lock_version", 0) + 1 WHERE ("merge_requests"."id") IN (SELECT "merge_requests"."id" FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 511) AND (cached_markdown_version < 2162697 OR ( cached_markdown_version IS NOT NULL AND title_html IS NULL AND description_html IS NULL ) OR ( cached_markdown_version IS NULL AND (title_html IS NOT NULL OR description_html IS NOT NULL) )) ORDER BY "merge_requests"."id" ASC LIMIT 100) /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
   Load (326.4ms)  SELECT "merge_requests".* FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 669) ORDER BY "merge_requests"."id" ASC LIMIT 2 OFFSET 99 /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
  #<Class:0x000000014ff59740> Update All (312.1ms)  UPDATE "merge_requests" SET "title_html" = NULL, "description_html" = NULL, "cached_markdown_version" = NULL, "lock_version" = COALESCE("lock_version", 0) + 1 WHERE ("merge_requests"."id") IN (SELECT "merge_requests"."id" FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 669) AND (cached_markdown_version < 2162697 OR ( cached_markdown_version IS NOT NULL AND title_html IS NULL AND description_html IS NULL ) OR ( cached_markdown_version IS NULL AND (title_html IS NOT NULL OR description_html IS NOT NULL) )) ORDER BY "merge_requests"."id" ASC LIMIT 100) /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
   Load (312.8ms)  SELECT "merge_requests".* FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 845) ORDER BY "merge_requests"."id" ASC LIMIT 2 OFFSET 99 /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
  #<Class:0x000000014ff59740> Update All (326.0ms)  UPDATE "merge_requests" SET "title_html" = NULL, "description_html" = NULL, "cached_markdown_version" = NULL, "lock_version" = COALESCE("lock_version", 0) + 1 WHERE ("merge_requests"."id") IN (SELECT "merge_requests"."id" FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 845) AND (cached_markdown_version < 2162697 OR ( cached_markdown_version IS NOT NULL AND title_html IS NULL AND description_html IS NULL ) OR ( cached_markdown_version IS NULL AND (title_html IS NOT NULL OR description_html IS NOT NULL) )) ORDER BY "merge_requests"."id" ASC LIMIT 100) /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
   Load (417.4ms)  SELECT "merge_requests".* FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 1011) ORDER BY "merge_requests"."id" ASC LIMIT 2 OFFSET 99 /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
  #<Class:0x000000014ff59740> Update All (311.5ms)  UPDATE "merge_requests" SET "title_html" = NULL, "description_html" = NULL, "cached_markdown_version" = NULL, "lock_version" = COALESCE("lock_version", 0) + 1 WHERE ("merge_requests"."id") IN (SELECT "merge_requests"."id" FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 1011) AND (cached_markdown_version < 2162697 OR ( cached_markdown_version IS NOT NULL AND title_html IS NULL AND description_html IS NULL ) OR ( cached_markdown_version IS NULL AND (title_html IS NOT NULL OR description_html IS NOT NULL) )) ORDER BY "merge_requests"."id" ASC LIMIT 100) /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
   Load (306.0ms)  SELECT "merge_requests".* FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 1142) ORDER BY "merge_requests"."id" ASC LIMIT 2 OFFSET 99 /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
  #<Class:0x000000014ff59740> Update All (323.1ms)  UPDATE "merge_requests" SET "title_html" = NULL, "description_html" = NULL, "cached_markdown_version" = NULL, "lock_version" = COALESCE("lock_version", 0) + 1 WHERE ("merge_requests"."id") IN (SELECT "merge_requests"."id" FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 1142) AND (cached_markdown_version < 2162697 OR ( cached_markdown_version IS NOT NULL AND title_html IS NULL AND description_html IS NULL ) OR ( cached_markdown_version IS NULL AND (title_html IS NOT NULL OR description_html IS NOT NULL) )) ORDER BY "merge_requests"."id" ASC LIMIT 100) /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
   Load (305.9ms)  SELECT "merge_requests".* FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 1320) ORDER BY "merge_requests"."id" ASC LIMIT 2 OFFSET 99 /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
  #<Class:0x000000014ff59740> Update All (310.3ms)  UPDATE "merge_requests" SET "title_html" = NULL, "description_html" = NULL, "cached_markdown_version" = NULL, "lock_version" = COALESCE("lock_version", 0) + 1 WHERE ("merge_requests"."id") IN (SELECT "merge_requests"."id" FROM "merge_requests" WHERE ("merge_requests"."id") <= (1505) AND ("merge_requests"."id" > 1320) AND (cached_markdown_version < 2162697 OR ( cached_markdown_version IS NOT NULL AND title_html IS NULL AND description_html IS NULL ) OR ( cached_markdown_version IS NULL AND (title_html IS NOT NULL OR description_html IS NOT NULL) )) ORDER BY "merge_requests"."id" ASC LIMIT 100) /*application:console,db_config_database:gitlabhq_dblab,db_config_name:main,console_hostname:zli--20240410-9YRFQ,console_username:zhaochen.li,line:/lib/gitlab/database/dynamic_model_helpers.rb:21:in `block in define_batchable_model'*/
=> nil
[7] pry(main)>

Testing

spec/lib/gitlab/background_operation/merge_requests_clear_stale_cached_html_spec.rb — clears rows below target, leaves rows at/above target untouched, and does not rewrite already-cleared (NULL) rows. 3 examples, 0 failures.

Related to #607937

Edited by zli

Merge request reports