Skip to content

Update diff line content on MR diffs to use actual HTML and not CSS element

David O'Regan requested to merge oregand/gitlab:202639 into master

What does this MR do?

On .com, when viewing a MR diff, we have replaced the line number insertion from a CSS before with actual HTML, rendered in the a tag.

Screenshots

Before After
Screenshot_2020-02-10_18-49-42 Screenshot_2020-02-10_18-50-54

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Unit tested added to: diff_line_gutter_content_spec.js to ensure a line number is rendered correctly by our component.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

References

Edited by Paul Slaughter

Merge request reports