Skip to content

Fix k8s logs alert display state

Adrien Kohlbecker requested to merge ak/fix-alert into master

What does this MR do?

In 518cb413 I mistakenly switched the display state of the elasticsearch call out alert.

Additionally, removing the condition on logs being loaded prevents it from jumping in and out of view. Indeed, this is not necessary anymore since the alert state is fully encapsulated in the environments API, and is thus isolated from the logs API.

Screenshots

Screenshot_2020-02-10_at_18.04.15

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports