Remove FinishedBuildsDeduplicatedFinder and deprecated mode argument
What does this MR do and why?
Follow-up cleanup after the BackfillCiFinishedBuildsToClickHouse BBM and mode-split removal. Two items were deliberately deferred one release to respect the Sidekiq backward-compatibility guidelines and keep the previous change focused.
Closes #604160.
Stacked MR: This targets the Plan A branch
narendran-kannan/592894/remove-backfill-bbm-modesplit(!247908 (merged)) because it depends on that MR having removed themode:parameter from the sync service and thebackfill_in_progress?branch that was the finder's only production caller. Retarget tomasteronce !247908 (merged) merges.
What this MR removes
ClickHouse::Finders::Ci::FinishedBuildsDeduplicatedFinderand its spec. It was only used by thebackfill_in_progress?branch inCi::JobAnalytics::QueryBuilder, which was removed in !247908 (merged). It is now unused in production code. Two comments in the siphon finders that referenced it as a conceptual analogue are updated accordingly.- The deprecated
_mode = nilargument fromClickHouse::CiFinishedBuildsSyncWorker#perform, plus the now-obsoleteloggable_argumentsindex. It was kept for one release per the Sidekiq compatibility guidelines so in-flight jobs scheduled with the old 3-arg signature would still execute. By 19.3 no such jobs can remain, so the argument is dropped.
Verification
$ bundle exec rspec \
ee/spec/workers/click_house/ci_finished_builds_sync_worker_spec.rb \
spec/lib/ci/job_analytics/query_builder_spec.rb
...
62 examples, 0 failuresRuboCop is clean on the touched files. Confirmed via grep that there are no remaining references to the deleted finder and no caller passes a third argument to the sync worker.
MR acceptance checklist
- I have evaluated the MR acceptance checklist for this MR.