Skip to content

Resolve "New re-usable component for Blob File Header"

Denys Mishunov requested to merge 196794-blob-header into master

What does this MR do?

Provides the last bit for the "New re-usable component for Blob File Header": namely, the header component itself that lays out and orchestrates all the relevant components (already merged).

This is supposed to be a stateless component for the purpose of it being used in both: Vuex- and Appollo-driven applications. Hence all the data management should happen in the parent component that contains the header (and sets the original state with props), while header components communicate back through eventHub.

NOTE: Since this MR is the part of a larger feature of refactoring Snippets view to Vue, this MR doesn't have own CHANGELOG entry.

Screenshots

Note, the visual difference in the icons has been handled in the respective components and should not be evaluated as part of this MR

Before After
Simple viewer Screenshot_2020-02-10_at_14.47.09 Screenshot_2020-02-10_at_14.47.25
Rich viewer Screenshot_2020-02-10_at_14.46.25 Screenshot_2020-02-10_at_14.46.02

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #196794 (closed)

Merge request reports