Skip to content

Fix signature badge popover not showing on Firefox

Tan Le requested to merge fix-signature-badge-popover into master

What does this MR do?

Fix signature badge popover not showing on Firefox and Safari.

This issue is reproducible on:

  • Firefox 72.0.2
  • Safari 13.0.5

Steps to reproduce

List commits page

  1. Navigate to the list commits page (e.g. https://gitlab.com/gitlab-org/gitlab/-/commits/master)
  2. Find a commit with Verified or Unverified signature badge Screen_Shot_2020-02-11_at_11.56.43_am
  3. Click on the badge to view more details
  4. The badge popover does not show on Firefox and Safari. It works in Chrome.

View commit page

  1. Navigate to the view commit page (e.g. f0897cb5)
  2. Click on the badge located on the header section to view more details Screen_Shot_2020-02-11_at_11.54.29_am
  3. The badge popover does not show on Firefox and Safari. It works in Chrome.

Project tree view page

  1. Navigate to the project tree view page (e.g. https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/spec/services/ee/users)
  2. Click on the badge located on the most recent commit section to view more details Screen_Shot_2020-02-11_at_12.25.46_pm
  3. The badge popover does not show on Firefox and Safari. It works in Chrome.

Screenshots

List commits page (after)

Screen_Shot_2020-02-10_at_11.48.19_am

View commit page (after)

Screen_Shot_2020-02-11_at_9.49.42_am

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tan Le

Merge request reports