Backport of Fix silent data loss in Advanced Search routing for >128 root_ancestor_ids
What does this MR do and why?
When searching with more than 128 root ancestor IDs, the routing logic in ee/lib/elastic/latest/routing.rb emits { routing: [] } which serializes to routing= (empty string). Elasticsearch interprets this as 'search zero shards', returning 0 hits with HTTP 200 — silent data loss that looks like a successful empty result.
Root cause: The root_ancestor_ids branch lacked the blank guard that the project_ids branch already has. When build_routing returns [] for >128 IDs, it was returned directly as { routing: [] } instead of falling back to an unrouted search.
Fix: Add return {} if routing.blank? to the root_ancestor_ids branch, matching the existing pattern in the project_ids branch. When root ancestor count exceeds 128, the search now degrades gracefully to an unrouted (all-shard) search returning all results.
See merge request !246079 (merged)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
- This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
- The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
- The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
- Required labels have been applied to this merge request
- severity label and bug subtype labels (if applicable)
- If this MR fixes a bug that affects customers, the customer label has been applied.
- This MR has been approved by a maintainer (only one approval is required).
- Ensure the
e2e:test-on-omnibus-eejob has succeeded, or if it has failed, investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releasesSlack channel (internal only). - Once the backport has been merged, the commit changes will be automatically deployed to a release environment that can be used for manual validation. See after merging runbook for details.