Skip to content

Properly update nuget package file size

David Fernandez requested to merge 10io-fix-nuget-package-file-size-update into master

What does this MR do?

Nuget package uploads are done using the multi part format. As such, the size of the request is unknown during the upload.

When processing a nuget package, we should properly update the package file size attribute using the file size from the object storage.

This MR is part of the nuget MVC (See the epic &2271 (closed)). This MR is gated behind this feature flag (scoped by project): nuget_package_registry. This MR doesn't need documentation or a change log entry.

Screenshots

Before this MR:

Screenshot_2020-02-07_at_15.44.28

After this MR:

Screenshot_2020-02-07_at_15.52.27

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Yorick Peterse

Merge request reports