Fix upstream bridge stuck when downstream pipeline is not pending
What does this MR do?
Looking at https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/models/ee/ci/pipeline.rb#L81. It seems currently we do not mark the upstream bridge as successful if the downstream pipeline status is not pending. This causes a stuck upstream bridge when for example pipeline status is manual
, preparing
, waiting_for_status
(via resource_group
) and so on.
We should fix this state machine to process the state machine event as created: any
Closes #202239 (closed)
QA
Confirmed on local environment that upstream bridge will succeed as soon as the downstream pipeline is created (transits its status from created
to whatever status e.g. pending
, skipped
, waiting_for_resource
)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team