Skip to content

Auto-require all cops

Peter Leitzen requested to merge pl-auto-require-all-cops into master

What does this MR do?

This MR removes the burden of every 👮 developer to require their cop in rubocop/rubocop.rb manually.

After @qzhaogitlab mentioned it in Slack https://gitlab.slack.com/archives/C8HG8D9MY/p1581056646202900 (internal) I've remembered that I've stumbled upon the very same issue at least twice.

@tkuah then asked:

Maybe it's time to automatically require the whole cop Dir?

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Thong Kuah

Merge request reports